Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTAL TA Sample Exam critical issues #63

Closed
danopolan opened this issue Jun 9, 2024 · 2 comments
Closed

CTAL TA Sample Exam critical issues #63

danopolan opened this issue Jun 9, 2024 · 2 comments
Assignees

Comments

@danopolan
Copy link
Contributor

We did not check Sample Exam for CTAL TA for some time and found several major issues in formatting.

  1. ONE option is indicated instead of TWO. This was changes in Sample Exam: Select TWO options in case of 5 option answers. #29 but doesn't work. Affected are questions 13 and 26.
    image

  2. Questions text overlap with a footer for questions 14 and 20. This is cause by not splitting questions across more pages, but we could lower top margin so the question starts higher and make tables bit smaller.
    image

  3. Answers explanation is a mess
    image

@Witiko
Copy link
Contributor

Witiko commented Jun 9, 2024

I assume this is related to https://github.com/istqborg/istqb-ctal-ta/pull/4.

  1. ONE option is indicated instead of TWO. Affected are questions 13 and 26.

This is due to an error in the input data, please see my review comments in https://github.com/istqborg/istqb-ctal-ta/pull/4:

As I offered in #29 (comment), I can strengthen the validation by requiring two correct answers for questions with five possible answers. This would allow us to catch such errors early. Furthermore, we may want to make the template smarter, so that it can understand both correct: [a, b] and correct: a, b even though the former is a YAML list and the latter is just text.

  1. Questions text overlap with a footer for questions 14 and 20. This is cause by not splitting questions across more pages, but we could lower top margin so the question starts higher and make tables bit smaller.

We anticipated this issue in #38 (comment) and already discussed a possible solution. I will take a look at implementing it on Monday at the latest.

  1. Answers explanation is a mess.

The results of CI for commit istqborg/istqb_product_template@adf5fc2 from May 3 contain answer explanations that look OK:

image

By contrast, the results of CI for commit istqborg/istqb_product_template@c09debd from today contain no questions or answers:

image

This indicates that there is a larger issue or possibly several issues at play, not just an issue with typesetting answer explanations.

Regardless, the issues seem to be regressions that have occurred in this repository since or after May 3, i.e. between commits 73d6e91 and 4793179. I will take a look at finding the regressions and fixing them on Monday.

@Witiko
Copy link
Contributor

Witiko commented Jun 10, 2024

This indicates that there is a larger issue or possibly several issues at play, not just an issue with typesetting answer explanations.

After applying the fix from commit ea5fee1 in PR #64, the results of CI for commit istqborg/istqb_product_template@c09debd from today look as follows:

image

This reproduces the issue from point 3 in the original post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants