Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IP_FAMILY env in favor of IP_FAMILIES #5572

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove IP_FAMILY env in favor of IP_FAMILIES #5572

merged 2 commits into from
Jan 17, 2025

Conversation

kfaseela
Copy link
Member

To be merged once istio/istio#54421 is merged

@kfaseela kfaseela requested a review from a team as a code owner January 15, 2025 21:27
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@kfaseela kfaseela added do-not-merge/hold Block automatic merging of a PR. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
dhawton
dhawton approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep DNM until istio/istio.io#16174 (review) merges. istio one already merged

@kfaseela
Copy link
Member Author

@sridhargaddam : I see usage of IP_FAMILY in sail-operator jobs, I have not explored how it is being used, feel free to change it if sail-operator wants to follow similar IP_FAMILIES approach

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@kfaseela
make gen
f0596d6 
Signed-off-by: Faseela K <[email protected]>
@sridhargaddam
Copy link
Contributor

@sridhargaddam : I see usage of IP_FAMILY in sail-operator jobs, I have not explored how it is being used, feel free to change it if sail-operator wants to follow similar IP_FAMILIES approach

Yes @kfaseela. I've taken care of it in Sail Operator itself without having to update the test-infra

@kfaseela kfaseela removed the do-not-merge/hold Block automatic merging of a PR. label Jan 17, 2025
@istio-testing istio-testing merged commit 6b4c891 into istio:master Jan 17, 2025
7 checks passed
@istio-testing
Copy link
Collaborator

@kfaseela: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key istio-private.istio.io.master.gen.yaml using file prow/cluster/jobs/istio-private/istio.io/istio-private.istio.io.master.gen.yaml
  • key istio-private.istio.master.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.master.gen.yaml
  • key istio.istio.io.master.gen.yaml using file prow/cluster/jobs/istio/istio.io/istio.istio.io.master.gen.yaml
  • key istio.istio.master.gen.yaml using file prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml
  • key istio.istioexperimental.gen.yaml using file prow/cluster/jobs/istio/istio/istio.istioexperimental.gen.yaml

In response to this:

To be merged once istio/istio#54421 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kfaseela
Copy link
Member Author

@sridhargaddam : I see usage of IP_FAMILY in sail-operator jobs, I have not explored how it is being used, feel free to change it if sail-operator wants to follow similar IP_FAMILIES approach

Yes @kfaseela. I've taken care of it in Sail Operator itself without having to update the test-infra

Does this require a change? https://github.com/istio/test-infra/blob/master/prow/config/jobs/sail-operator.yaml#L50

@sridhargaddam
Copy link
Contributor

Does this require a change? https://github.com/istio/test-infra/blob/master/prow/config/jobs/sail-operator.yaml#L50

KIND_IP_FAMILY will be configured based on the IP_FAMILY. So, we do not require any changes in the test-infra repo.

@kfaseela kfaseela mentioned this pull request Jan 20, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhawton dhawton dhawton approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfaseela @sridhargaddam @istio-testing @dhawton