Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DualStack e2e tests failing due to upstream changes in IP_FAMILIES handling #558

Closed
1 task done
Tracked by #54127
sridhargaddam opened this issue Jan 16, 2025 · 0 comments · Fixed by #559
Closed
1 task done
Tracked by #54127

DualStack e2e tests failing due to upstream changes in IP_FAMILIES handling #558

sridhargaddam opened this issue Jan 16, 2025 · 0 comments · Fixed by #559
Assignees
Labels
bug Something isn't working

Comments

@sridhargaddam
Copy link
Contributor

sridhargaddam commented Jan 16, 2025

Is this the right place to submit this?

  • This is not a question about how to use the sail-operator

Bug Description

Recently, the following PRs in the Istio project introduced the IP_FAMILIES flag for validating dual-stack use cases. This flag can be set to IPv4, IPv6, "IPv4,IPv6", or "IPv6,IPv4", where specifying both families indicates a dual-stack cluster, with the order representing preference.

The relevant PRs are:

Currently, Sail Operator's e2e tests validate dual-stack environments, but they do not consider the order of ipFamilies.
Due to the above changes, the automation job that sync's upstream changes into Sail Operator is failing, and we need to fix it.

@sridhargaddam sridhargaddam added the bug Something isn't working label Jan 16, 2025
@sridhargaddam sridhargaddam self-assigned this Jan 16, 2025
sridhargaddam added a commit to sridhargaddam/sail-operator that referenced this issue Jan 16, 2025
This PR sets KIND_IP_FAMILY to align with the IP_FAMILY used in
Sail Operator scripts. Since the order of IP families is not
relevant for Sail Operator e2e tests, we do not require the
IP_FAMILIES variable used upstream.

Fixes: istio-ecosystem#558
Signed-off-by: Sridhar Gaddam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant