-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable QAT key provider #5425
Enable QAT key provider #5425
Conversation
Signed-off-by: He Jie Xu <[email protected]>
Hi @soulxu. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
We probably need to wait the istio proxy update to the latest envoy. |
wait for #5426 |
/test release-test |
@soulxu can you share the root cause? is there anything we can do at envoy repo to prevent this happen again? |
@zirain, I find some useless building parameters were added by PR. And those parameters lead to we build some shared library which qat provider key provider doesn't need actually. But I can't figure out why those build error only happened on the istio ci, since I also can't reproduce this compile error in my local. |
What this PR does / why we need it:
The qat key provider was disabled due to CI breaking #5411 (comment), now the build issue was fixed by envoyproxy/envoy#33143, so enable it again.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #5411Special notes for your reviewer: