Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QAT key provider #5425

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Enable QAT key provider #5425

merged 1 commit into from
Mar 28, 2024

Conversation

soulxu
Copy link
Contributor

@soulxu soulxu commented Mar 27, 2024

What this PR does / why we need it:

The qat key provider was disabled due to CI breaking #5411 (comment), now the build issue was fixed by envoyproxy/envoy#33143, so enable it again.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #5411

Special notes for your reviewer:

Signed-off-by: He Jie Xu <[email protected]>
@soulxu soulxu requested a review from a team as a code owner March 27, 2024 13:40
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Mar 27, 2024
@istio-testing
Copy link
Collaborator

Hi @soulxu. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lei-tang
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 27, 2024
@soulxu
Copy link
Contributor Author

soulxu commented Mar 28, 2024

We probably need to wait the istio proxy update to the latest envoy.

@zirain
Copy link
Member

zirain commented Mar 28, 2024

wait for #5426

@ericvn
Copy link

ericvn commented Mar 28, 2024

/test release-test

@zirain
Copy link
Member

zirain commented Mar 28, 2024

@soulxu can you share the root cause? is there anything we can do at envoy repo to prevent this happen again?

@istio-testing istio-testing merged commit 7aa67c2 into istio:master Mar 28, 2024
9 checks passed
@soulxu
Copy link
Contributor Author

soulxu commented Mar 30, 2024

@soulxu can you share the root cause? is there anything we can do at envoy repo to prevent this happen again?

@zirain, I find some useless building parameters were added by PR. And those parameters lead to we build some shared library which qat provider key provider doesn't need actually. But I can't figure out why those build error only happened on the istio ci, since I also can't reproduce this compile error in my local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants