contrib: add qatzstd compressor #32166
Conversation
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
giantcroc
force-pushed
the
zstd_upstream
branch
from
b8ec4ae to
40edf73
Compare
|
sorry, has to use force-push to fix DCO issue. |
|
/assign @soulxu |
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
api/contrib/envoy/extensions/compression/qatzstd/compressor/v3alpha/qatzstd.proto
Show resolved
Hide resolved
api/contrib/envoy/extensions/compression/qatzstd/compressor/v3alpha/qatzstd.proto
Show resolved
Hide resolved
api/contrib/envoy/extensions/compression/qatzstd/compressor/v3alpha/qatzstd.proto
Outdated
Show resolved
Hide resolved
contrib/qat/compression/qatzstd/compressor/source/qatzstd_compressor_impl.h
Outdated
Show resolved
Hide resolved
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
|
cc @htuch would you like to talk a look at this PR? thanks! |
bazel/foreign_cc/qatzstd.patch
Outdated
| - QATFLAGS += -DENABLE_USDM_DRV | ||
| - LDFLAGS += -lusdm | ||
| - endif | ||
| + QATFLAGS += -DENABLE_USDM_DRV |
There was a problem hiding this comment.
This PR in general is LGTM except for this patch. Is there a way you can make changes upstream so Envoy builds patch-less? Thanks. This really helps with maintenance.
There was a problem hiding this comment.
Hi, we have reduced most of the patch, and the remaining code in the patch will be updated in next release, let me know if this is acceptable, thanks!
There was a problem hiding this comment.
OK, thanks, I think this is fine, in particular if this is gone in the next release. Appreciate the upstream work here!
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: giantcroc <[email protected]>
repokitteh-read-only
bot
removed
the
deps
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@phlax Hi, the CI seems get stuck, could you help to fix it so that we can merge this PR? Thanks! |
|
@giantcroc would you mind to submit a empty commit, then retrigger the CI, then I can help you merge the PR |
Signed-off-by: giantcroc <[email protected]>
Sure, thanks! |
|
apologies i missed the earlier ping - ill push this through now |
Commit Message: add qatzstd compressor as contrib extension #32165
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]