Add some integration tests #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qiwzhang
commented
Sep 30, 2017
qiwzhang
commented
- Test Mixer return INTERNAL error, with fail_close and fail_open policy
- Test adding fault http filter after mixer filter to make sure Check and Report are called.
|
Jenkins job proxy/presubmit passed |
lizan
reviewed
Sep 30, 2017
| @@ -32,7 +32,7 @@ func TestFailClose(t *testing.T) { | |||
|
|
|||
| url := fmt.Sprintf("http://localhost:%d/echo", ClientProxyPort) | |||
|
|
|||
| tag := "Fail-Open" | |||
| tag := "Fail-CLOSE" | |||
| t *testing.T | ||
| conf string | ||
| stress bool | ||
| fault_inject bool |
There was a problem hiding this comment.
nit: faultInject and noMixer
|
Jenkins job proxy/presubmit passed |
|
Jenkins job proxy/pilot-regression passed |
lizan
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.