Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

httpFault/abort rules trigger does not send data to Prometheus #133

Closed
mandarjog opened this issue Sep 29, 2017 · 1 comment
Closed

httpFault/abort rules trigger does not send data to Prometheus #133

mandarjog opened this issue Sep 29, 2017 · 1 comment
Assignees

Comments

@mandarjog
Copy link
Contributor

@esnible commented on Tue May 30 2017

To reproduce, start up bookinfo.

cat << EOF |
type: route-rule
name: ratings-fail-xpercent
spec:
  destination: ratings.default.svc.cluster.local
  precedence: 2
  httpFault:
    abort:
      percent: 95
      httpStatus: 500
EOF
istioctl replace

Drive some traffic. Then look at the output in Prometheus or ServiceGraph. The traffic is reduced by the %, but there are no response_code entries for the injected 500s.


@ZackButcher commented on Tue May 30 2017

This is likely a problem in either Envoy's Mixer filter or the mixerclient itself. Mixer just blindly pushes the data we're provided to the metric backend, these missing stats seem to indicate that Report calls aren't being made to the mixer by Envoy when it sees a 500.


@douglas-reid commented on Tue May 30 2017

@qiwzhang any ideas what might cause this related to the filter chain?

@qiwzhang
Copy link
Contributor

@esnible could you test it with latest Istio (0.2.6)? As long as fault fitler is injected after mixer filter, it should work. I just checked, now it is injected after.

https://github.com/istio/pilot/blob/master/proxy/envoy/testdata/lds-v0-fault.json.golden#L184

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants