Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-translation:/docs/reference/glossary/workload-instance.md #5725

Merged
merged 2 commits into from
Dec 3, 2019
Merged

zh-translation:/docs/reference/glossary/workload-instance.md #5725

merged 2 commits into from
Dec 3, 2019

Conversation

zxh326
Copy link
Contributor

@zxh326 zxh326 commented Nov 15, 2019 •
edited by istio-policy-bot
Loading

@zxh326 zxh326 requested a review from a team as a code owner November 15, 2019 16:13
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 15, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 15, 2019
@istio-testing
Copy link
Contributor

Hi @zxh326. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zxh326 zxh326 mentioned this pull request Nov 20, 2019
Closed
@tanjunchen
Copy link
Member

Fix conflicts.Thanks

@tanjunchen tanjunchen self-requested a review December 2, 2019 05:18
@tanjunchen
Copy link
Member

/lgtm
@rootsongjc

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 3, 2019
rootsongjc
rootsongjc approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing istio-testing merged commit f0b462c into istio:master Dec 3, 2019
brian-avery pushed a commit to brian-avery/istio.github.io that referenced this pull request Dec 3, 2019
@zxh326 @brian-avery
zh-translation:/docs/reference/glossary/workload-instance.md (istio#5725
4a623a6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootsongjc rootsongjc rootsongjc approved these changes

@tanjunchen tanjunchen Awaiting requested review from tanjunchen

Assignees

@tanjunchen tanjunchen

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zxh326 @istio-testing @tanjunchen @rootsongjc @googlebot @istio-policy-bot