Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove glob from tap command-line #92

Closed
wants to merge 3 commits into from

Conversation

coreyfarrell
Copy link
Member

Update to [email protected] to fix a bug where command-line glob was required
under Windows.

Update to [email protected] to fix a bug where command-line glob was required
under Windows.
@isaacs
Copy link
Collaborator

isaacs commented May 17, 2019

It works for me locally on windows. Not sure what's going on with Travis.

C:\spawn-wrap>npm t

> [email protected] test C:\spawn-wrap
> tap

 SKIP  test/abs-shebang.js > No proper shebang support on windows, so skip this 648ms
 SKIP  TAP
 ~ test/abs-shebang.js > No proper shebang support on windows, so skip this

 SKIP  test/basic.js
 ~ SIGINT > no signals get through cmd

 SKIP  test/basic.js
 ~ SIGHUP > no signals get through cmd

 PASS  test/double-wrap.js 3 OK 1s
 SKIP  test/basic.js
 ~ SIGINT > no signals get through cmd

 SKIP  test/basic.js
 ~ SIGHUP > no signals get through cmd

 SKIP  test/basic.js
 ~ SIGINT > no signals get through cmd

 SKIP  test/basic.js
 ~ SIGHUP > no signals get through cmd

 SKIP  test/basic.js
 ~ exec shebang > no shebang execution on windows

 SKIP  test/basic.js
 ~ Node 5.8.x + npm 3.7.x - spawn > no shebang execution on windows

 PASS  test/exec-flag.js 2 OK 1s
 SKIP  test/basic.js
 ~ Node 5.8.x + npm 3.7.x - shell > no shebang execution on windows

 SKIP  test/basic.js 9 skip of 34 3s
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ exec shebang > no shebang execution on windows
 ~ Node 5.8.x + npm 3.7.x - spawn > no shebang execution on windows
 ~ Node 5.8.x + npm 3.7.x - shell > no shebang execution on windows

 PASS  test/wrap-twice.js 3 OK 1s


  🌈 SUMMARY RESULTS 🌈


 SKIP  test/abs-shebang.js > No proper shebang support on windows, so skip this 648ms
 SKIP  test/basic.js 9 skip of 34 3s
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ SIGINT > no signals get through cmd
 ~ SIGHUP > no signals get through cmd
 ~ exec shebang > no shebang execution on windows
 ~ Node 5.8.x + npm 3.7.x - spawn > no shebang execution on windows
 ~ Node 5.8.x + npm 3.7.x - shell > no shebang execution on windows

Suites:   4 passed, 1 skip, 5 of 5 completed
Asserts:  33 passed, 10 skip, of 43
Time:     4s

C:\spawn-wrap>npx tap --version
13.1.10

@coreyfarrell
Copy link
Member Author

@isaacs Any debug we can enable to troubleshoot further?

@isaacs
Copy link
Collaborator

isaacs commented May 17, 2019

Yeh, set NODE_DEBUG=tap, and it'll dump a lot of stuff.

@coreyfarrell
Copy link
Member Author

Abandon this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants