Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use Travis for Windows tests #82

Merged
merged 1 commit into from
May 10, 2019

Conversation

demurgos
Copy link
Contributor

@demurgos demurgos commented May 9, 2019

This commit updates the CI config to only use Travis for both Linux and Windows tests. It means that it removes the integration with AppVeyor.

@demurgos demurgos changed the title chore: Use Travis for Windows and OS X tests chore: Use Travis for Windows tests May 9, 2019
@demurgos
Copy link
Contributor Author

demurgos commented May 9, 2019

The tests hang on Windows. I'll have to take a closer look at the issue.

This commit updates the CI config to only use Travis for both Linux and Windows tests. It means that it removes the integration with AppVeyor.
@demurgos
Copy link
Contributor Author

Fixed, the issue was caused by the test command missing the file glob.

@coreyfarrell
Copy link
Member

I posted a bug at tapjs/tapjs#554, as far as I know the glob is not supposed to be required for tapjs@13. Either way this gets us testing on Windows so I'll merge even if we later remove the glob.

@coreyfarrell coreyfarrell merged commit 4a06beb into istanbuljs:master May 10, 2019
@demurgos demurgos deleted the travis-only branch May 10, 2019 11:49
@isaacs
Copy link
Collaborator

isaacs commented May 17, 2019

The regexp on windows issue is fixed in tap v13.1.10 tapjs/tapjs@a9bd8f3

@coreyfarrell
Copy link
Member

@isaacs we're still having the issue after updating tap, see #92. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants