Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reproducibility of initial conditions with the same random seed #12

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

danielhollas
Copy link
Member

@danielhollas danielhollas commented Nov 3, 2024

Although we were initializing the PRNG with the random seed correctly, we then forgot to use it. :-(
This is embarassing, but fortunately does not affect the code in Atmospec which does it correctly.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.71%. Comparing base (b183e05) to head (6528d3c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
+ Coverage   15.38%   48.71%   +33.33%     
===========================================
  Files           3        3               
  Lines         117      117               
===========================================
+ Hits           18       57       +39     
+ Misses         99       60       -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas
Copy link
Member Author

@JanosJiri let me know if you'd like me to tag you for reviews on harmonwig PRs. :-)

Copy link

@juraskov juraskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Kudos for fixing a bug!

@danielhollas danielhollas merged commit 453b080 into main Nov 3, 2024
9 checks passed
@danielhollas danielhollas deleted the fix-seed-bug branch November 3, 2024 15:03
@JanosJiri
Copy link

@JanosJiri let me know if you'd like me to tag you for reviews on harmonwig PRs. :-)

Why not, although I am late here. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants