Skip to content

Commit

Permalink
Add failing test for reproducibility with the same rnd seed
Browse files Browse the repository at this point in the history
  • Loading branch information
danielhollas committed Nov 3, 2024
1 parent b183e05 commit e761aa1
Showing 1 changed file with 82 additions and 0 deletions.
82 changes: 82 additions & 0 deletions tests/test_harmonicwigner_class.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import numpy as np
import pytest
from ase import Atoms

from harmonwig import HarmonicWigner


@pytest.fixture
def mock_h2o_molecule():
"""Create a simple water molecule for testing"""
positions = [
[0.0, 0.0, 0.0], # O
[0.0, 0.757, 0.586], # H
[0.0, -0.757, 0.586],
] # H
return Atoms("OH2", positions=positions)


@pytest.fixture
def mock_h2o_frequencies():
"""Mock H2O vibrational frequencies in cm^-1"""
# Real vibrational frequencies for H2O
return [
3657.0, # symmetric stretch
3756.0, # antisymmetric stretch
1595.0,
] # bending


@pytest.fixture
def mock_h2o_vibrations():
"""Mock vibrational normal modes"""
# Simplified normal modes for testing
vibrations = []

# Symmetric stretch - both H atoms move in same direction
vibrations.append(
[
[0.0, 0.0, 0.0], # O stays relatively still
[0.0, 0.0, 1.0], # H1 moves up
[0.0, 0.0, 1.0], # H2 moves up
]
)

# Antisymmetric stretch - H atoms move in opposite directions
vibrations.append(
[
[0.0, 0.0, 0.0], # O stays relatively still
[0.0, 0.0, 1.0], # H1 moves up
[0.0, 0.0, -1.0], # H2 moves down
]
)

# Bending - H atoms move in opposite directions perpendicular to bonds
vibrations.append(
[
[0.0, 0.0, 0.0], # O stays relatively still
[0.0, 1.0, 0.0], # H1 moves right
[0.0, -1.0, 0.0], # H2 moves left
]
)

return vibrations


def test_sample_reproducibility(
mock_h2o_molecule, mock_h2o_frequencies, mock_h2o_vibrations
):
"""Test that using the same seed produces identical samples"""
hw1 = HarmonicWigner(
mock_h2o_molecule, mock_h2o_frequencies, mock_h2o_vibrations, seed=42
)

hw2 = HarmonicWigner(
mock_h2o_molecule, mock_h2o_frequencies, mock_h2o_vibrations, seed=42
)

sample1 = hw1.get_ase_sample()
sample2 = hw2.get_ase_sample()

# Positions should be identical for same seed
np.testing.assert_array_equal(sample1.get_positions(), sample2.get_positions())

0 comments on commit e761aa1

Please sign in to comment.