chore(mergify): enhance mergify #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,9 +15,9 @@ pull_request_rules: | |||
| conditions: | |||
| - author=snyk-bot | |||
| - check-success~=lint | |||
| - check-success~=build | |||
There was a problem hiding this comment.
may i get context for this regarding why this line was removed?
There was a problem hiding this comment.
added back in, removed by accident.
kishore03109
reviewed
Apr 9, 2024
| - check-success~=test | ||
| - dependabot-update-type = version-update:semver-minor | ||
| - -dependabot-update-type = version-update:semver-major |
There was a problem hiding this comment.
wait am a bit confused, should this not be minor then, according to the pr desc?
There was a problem hiding this comment.
didn't duplicate the comment here but this negates the condition so this is essentially everything but major (minor + patches)
kishore03109
approved these changes
Apr 11, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
package updates are not automated and we have to look through even minor ones. minor updates should be approved + merged automatically
Solution
update dependabot config to merge minor packages automatically. we auto-merge snyk cos is security issue (open to also changing this to minor)