Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enhance mergify #1245

Merged
merged 3 commits into from
Apr 8, 2024
Merged

chore(ci): enhance mergify #1245

merged 3 commits into from
Apr 8, 2024

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Mar 27, 2024

Problem

see here

Solution

see here

@seaerchin seaerchin changed the title Chore/mergify chore(ci): enhance mergify Mar 27, 2024
@seaerchin seaerchin marked this pull request as ready for review March 27, 2024 15:21
@seaerchin seaerchin requested a review from a team March 27, 2024 15:21
kishore03109
kishore03109 previously approved these changes Apr 1, 2024
@@ -4,7 +4,7 @@ pull_request_rules:
- author~=^dependabot\[bot\]$
- check-success~=lint
- check-success~=test
- title~=bump [^\s]+ from ([\d]+)\..+ to \1\.
- dependabot-update-type = version-update:semver-minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one does from minor all the way to major right? if not please dismiss my approval!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, only semver-minor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misunderstood this pr, what about patches ya?

i think lets just do

- -dependabot-update-type = version-update:semver-major

which auto-merges everything less semver-major
Screenshot 2024-04-02 at 7 32 23 PM

@kishore03109 kishore03109 dismissed their stale review April 1, 2024 06:18

Misunderstood this pr, what about patches ya?

@seaerchin seaerchin requested review from kishore03109 and a team April 2, 2024 11:37
@seaerchin seaerchin merged commit d324c3b into develop Apr 8, 2024
13 checks passed
@seaerchin seaerchin deleted the chore/mergify branch April 8, 2024 14:34
@harishv7 harishv7 mentioned this pull request Apr 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants