Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.43.0 #1492

Merged
merged 4 commits into from
Sep 14, 2023
Merged

0.43.0 #1492

merged 4 commits into from
Sep 14, 2023

Conversation

kishore03109
Copy link
Contributor

v0.43.0

  • fix(herobody): solves empty highlight deafult issue #1489
  • fix(edithomepage): spread properly #1487
  • Release/0.42.0 (develop) #1481

alexanderleegs and others added 4 commits September 7, 2023 15:38
* fix(edithomepage): spread properly

* fix(dropdown): update after rebase

---------

Co-authored-by: seaerchin <[email protected]>
* fix(herobody): solves empty highlight deafult issue

* fix: add default for hero dropdown

* chore: swap intialSectionType selector to follow conditional

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: Alexander Lee <[email protected]>
@kishore03109 kishore03109 changed the base branch from develop to master September 13, 2023 10:04
@kishore03109 kishore03109 mentioned this pull request Sep 13, 2023
@kishore03109 kishore03109 temporarily deployed to staging September 13, 2023 10:12 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 13, 2023 10:14 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 13, 2023 10:15 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 13, 2023 10:16 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 13, 2023 10:17 — with GitHub Actions Inactive
@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 14, 2023

fix(edithomepage): spread properly #1487
Tests

  • on initial load, the button/url should both contain the properties of the button on the preview
  • on save + reload, the new changes should be persisted to the input

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 14, 2023

fix(herobody): solves empty highlight deafult issue #1489

Tests

  • go to a site
  • delete all highlights and make highlight the selected option
  • click save
  • reload the page
  • click add highlight option
  • a highlight should show on previwe

@kishore03109
Copy link
Contributor Author

Arh, so E2E did not run since at first this was to dev, switched to master, and our cicd dont tackle on edits (rightfully so since we dont want multiple runs due to like comment level edits).
Closing and repoening pr to trigger e2e for ci

@kishore03109 kishore03109 reopened this Sep 14, 2023
@kishore03109 kishore03109 temporarily deployed to staging September 14, 2023 01:57 — with GitHub Actions Inactive
@kishore03109 kishore03109 merged commit 8c31ece into master Sep 14, 2023
29 of 30 checks passed
@mergify mergify bot deleted the release/0.43.0 branch September 14, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants