Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edithomepage): spread properly #1487

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix(edithomepage): spread properly #1487

merged 2 commits into from
Sep 13, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

Previously the highlight section was missing properties due to a missing spread after rebase (sadge). This led to the input being blank on initial load (edits etc will still work)

Solution

spread the property of section.hero

Tests

  • on initial load, the button/url should both contain the properties of the button on the preview
  • on save + reload, the new changes should be persisted to the input

@seaerchin seaerchin requested a review from a team September 12, 2023 06:01
@seaerchin seaerchin temporarily deployed to staging September 12, 2023 06:21 — with GitHub Actions Inactive
@seaerchin seaerchin merged commit bbaaf81 into develop Sep 13, 2023
6 checks passed
@seaerchin seaerchin deleted the fix/highlights branch September 13, 2023 09:07
This was referenced Sep 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs