Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Homarus #12

Merged
merged 14 commits into from
Nov 20, 2018
Merged

Homarus #12

merged 14 commits into from
Nov 20, 2018

Conversation

Natkeeran
Copy link
Contributor

GitHub Issue: (link)
Islandora/documentation#929

What does this Pull Request do?

This PR along with related PRs adds a php micro service that creates video derivatives using ffmpeg.

How should this be tested?

As this relies on several other PRs, it is bit tricky to test. You can modify the requirements.yml with the following.

- src: https://github.com/Natkeeran/ansible-role-crayfish
  name: Islandora-Devops.crayfish
  version: homarus

Note that ansible-role-crayfish is pointing the branch in my local repo.

This PR needs to be merged: Islandora/Crayfish-Commons#20.

After that

  • Create a test video by going here: http://localhost:8080/fcrepo/rest/ and uploading a binary
  • Test via curl as below or using Postman
curl -H "Authorization: Bearer islandora" -H "Accept: video/x-msvideo" -H "Apix-Ldp-Resource:http://localhost:8080/fcrepo/rest/testvideo" http://localhost:8000/homarus/convert --output output.avi

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

@Natkeeran
Copy link
Contributor Author

Natkeeran commented Nov 7, 2018

@dannylamb

It would be good if you can give this a test.

The way I test is as follows:

In the requirments.yml in claw-playbook, I change it to point to this branch:

- src: https://github.com/Natkeeran/ansible-role-crayfish
  name: Islandora-Devops.crayfish
  version: homarus

Then, I have to change the crayfish-commons in the vendor with this branch: https://github.com/Natkeeran/Crayfish-Commons/tree/http_source

Please note that this branch is pointing to my Crayfish branch. When merging, that reference has to be changed: Natkeeran@01a8e58.

I am not sure of another way to test this.

@dannylamb
Copy link
Contributor

@Natkeeran Ran it yesterday and didn't get your role for some reason. I'm going to destroy roles/external and try again. Probably just a cached version.

@Natkeeran
Copy link
Contributor Author

@dannylamb Yes, you have to delete that folder or the entire play8book and vagrant up again. Otherwise, it will just use the existing one.

@dannylamb
Copy link
Contributor

This is still giving me grief. Just blew away my whole claw-plabyook directory and re-cloning to see if that does anything. I updated to Ansible 2.7.1 to recreate Islandora/documentation#973, and am starting to believe I'm experiencing more fallout from that. I download the role alright, but the homarus branch of Crayfish is not pulled down, nor is the install any different so far as I can tell.

@dannylamb
Copy link
Contributor

Re-cloning claw-playbook did it! 🎆 🍾

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't install ffmpeg. Should just be able to add it here for Ubuntu and here for Centos. Tho I'm not sure if the package name is ffmpeg in Centos as it is in Ubuntu

@MarcusBarnes
Copy link

I've tested using Ubuntu. It worked as described. Please note that currently, you'll need to install ffmpeg. On Ubuntu, after vagrant ssh, run sudo apt-get install ffmpeg.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome, thx! Go ahead and revert tasks/install.yml to point back to the foundation repo and I'll merge this in!

@Natkeeran
Copy link
Contributor Author

@dannylamb

I've updated it.

I'll have to let @seth-shaw-unlv or someone more familiar with Centos to add the ffmpeg installation.

Note that Islandora/Crayfish#52 needs to be merged first and then the release tag updated in the requirements.

@dannylamb
Copy link
Contributor

@Natkeeran Can you update https://github.com/Islandora-Devops/ansible-role-crayfish/blob/master/defaults/main.yml#L1 to 0.0.11 to match the new version of Crayfish I just sliced? Then I'll merge this, slice a version, and we can update requirements.yml to point to it.

@Natkeeran
Copy link
Contributor Author

@dannylamb updated.

@dannylamb dannylamb merged commit 3f3c3e7 into islandora-deprecated:master Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants