-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
It would be good if you can give this a test. The way I test is as follows: In the requirments.yml in claw-playbook, I change it to point to this branch:
Please note that this branch is pointing to my Crayfish branch. When merging, that reference has to be changed: Natkeeran@01a8e58. I am not sure of another way to test this. |
@Natkeeran Ran it yesterday and didn't get your role for some reason. I'm going to destroy |
@dannylamb Yes, you have to delete that folder or the entire play8book and vagrant up again. Otherwise, it will just use the existing one. |
This is still giving me grief. Just blew away my whole claw-plabyook directory and re-cloning to see if that does anything. I updated to Ansible 2.7.1 to recreate Islandora/documentation#973, and am starting to believe I'm experiencing more fallout from that. I download the role alright, but the homarus branch of Crayfish is not pulled down, nor is the install any different so far as I can tell. |
Re-cloning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested using Ubuntu. It worked as described. Please note that currently, you'll need to install ffmpeg. On Ubuntu, after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Awesome, thx! Go ahead and revert tasks/install.yml
to point back to the foundation repo and I'll merge this in!
I've updated it. I'll have to let @seth-shaw-unlv or someone more familiar with Centos to add the ffmpeg installation. Note that Islandora/Crayfish#52 needs to be merged first and then the release tag updated in the requirements. |
@Natkeeran Can you update https://github.com/Islandora-Devops/ansible-role-crayfish/blob/master/defaults/main.yml#L1 to 0.0.11 to match the new version of Crayfish I just sliced? Then I'll merge this, slice a version, and we can update requirements.yml to point to it. |
@dannylamb updated. |
GitHub Issue: (link)
Islandora/documentation#929
What does this Pull Request do?
This PR along with related PRs adds a php micro service that creates video derivatives using ffmpeg.
How should this be tested?
As this relies on several other PRs, it is bit tricky to test. You can modify the requirements.yml with the following.
Note that ansible-role-crayfish is pointing the branch in my local repo.
This PR needs to be merged: Islandora/Crayfish-Commons#20.
After that
http://localhost:8080/fcrepo/rest/
and uploading a binaryInterested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers