consider as uri if it is not a resource

[Natkeeran]

GitHub Issue: (link)
Islandora/documentation#943

What does this Pull Request do?

This PR will tell Crayfish-Commons to not to load $data into the pipe if it is not a resource. It is assumed that a resource url will be passed in. Specifically to address the above 943 ffmpeg issue.

How should this be tested?

This needs to be tested other related PRs. Which I will post shortly here.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

[dannylamb]

phpcbf can take care of Travis: https://travis-ci.com/Islandora-CLAW/Crayfish-Commons/jobs/156095121

[dannylamb]

linking to Islandora/Crayfish#52

[codecov]

Codecov Report

Merging #20 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     78.91%   78.67%   -0.24%     
- Complexity      109      110       +1     
============================================
  Files             8        8              
  Lines           332      333       +1     
============================================
  Hits            262      262              
- Misses           70       71       +1

Impacted Files	Coverage Δ	Complexity Δ
src/CmdExecuteService.php	4.76% <0%> (-0.12%)	13 <0> (+1)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209117a...a0b07f7. Read the comment docs.

[dannylamb]

Shouldn't hurt anything to pull this in now. Let's do it 👍

[dannylamb]

Codecov forced me to use admin privileges to merge that because coverage dropped by a tiny percentage. I should go through our repos and disable that so it's not a 'required' status check and instead just a tool of guilt.

[dannylamb]

Eww... so I don't know if I can do that...

It's either required or not a status check at all. I wonder if it will still run when not a status check? Only one way to find out.

[whikloj]

It won't run, we should keep it as required and figure out why coverage dropped and add tests so it doesn't.

[whikloj]

Actually we have no tests for the CmdExecuteService so adding any complexity to it reduces the overall coverage. We should add tests for this service.