Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

348 - cleaning up the aria divs if all the dnd zones were destroyed and initializing only when the first one is initialized #350

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

isaacHagoel
Copy link
Owner

cleaning up the aria divs if all the dnd zones were destroyed and initializing only when the first one is initialized
fixes #348

…nd initializing only when the first one is initialized
@jeffalo
Copy link

jeffalo commented Feb 6, 2022

I can't navigate back to a page that doesn't use the action. I just see a blank screen and this error message:

image

This occurs in production and development

@isaacHagoel
Copy link
Owner Author

isaacHagoel commented Feb 7, 2022 via email

@jeffalo
Copy link

jeffalo commented Feb 12, 2022

It works fine when I navigate from a page without it, to a page that uses it. But if I directly load a page that uses it, the accessibility divs don't get added, and I get this error:
image

@isaacHagoel
Copy link
Owner Author

isaacHagoel commented Feb 12, 2022 via email

@isaacHagoel
Copy link
Owner Author

@jeffalo based on the error message you've included it looks like you were using alertToScreenReader which was relying on these divs being there in order to function. I made it more robust and tested locally on a svelteKit app. Please pull and try again. should be good now.

@isaacHagoel isaacHagoel marked this pull request as ready for review February 18, 2022 22:52
@isaacHagoel isaacHagoel merged commit 442e391 into master Feb 18, 2022
@isaacHagoel isaacHagoel deleted the 348-clean-up-aria branch February 18, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria attributes added to every page when using SvelteKit
2 participants