aria attributes added to every page when using SvelteKit

[jeffalo]

Firstly, Thank you for making this great package. :)

When using svelte-dnd-action within a SvelteKit app, I'm seeing the aria attributes and alerts get added to every page:

(This only occurs in production builds)

This is not ideal, as Google thinks it should be the description of my website instead of the stuff I provide.

I am currently importing the svelte-dnd-action under a component used on 2 pages, however the alerts elements are being added on all pages, regardless of whether I have visited a page using the component.

Is this normal, and is there a way to not have them get added on every page?

[isaacHagoel]

What kind of solution would you suggest? Thx

…

On Thu, Feb 3, 2022, 06:42 jeffalo ***@***.***> wrote: Firstly, Thank you for making this great package. :) When using svelte-dnd-action within a SvelteKit app, I'm seeing the aria attributes and alerts get added to every page: [image: image] <https://user-images.githubusercontent.com/40470736/152224465-4b29b255-f47c-4fc3-8c55-a7cb33faffbe.png> This is not ideal, as Google thinks it should be the description of my website instead of the stuff I provide. I am currently importing the svelte-dnd-action under a component used on 2 pages, however the alerts elements are being added on all pages, regardless of whether I have visited a page using the component. Is this normal, and is there a way to not have them get added on every page? I chose to set autoAriaDisabled to true for now, but it's not a great solution. — Reply to this email directly, view it on GitHub <#348>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4OZCYKLTK2ETFW2TPCMPTUZGCJ5ANCNFSM5NM6XE3Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jeffalo]

If the divs were only added to pages that actually use the dnd action would that be a good enough solution? And if they were removed on destroy?

[isaacHagoel]

so we're talking about the divs that are added to the document itself? they are added when importing the lib. do all pages import it regardless of whether they use it?

…

On Thu, Feb 3, 2022 at 7:26 AM jeffalo ***@***.***> wrote: If the divs were only added to pages that actually use the dnd action would that be a good enough solution? And if they were removed on destroy? — Reply to this email directly, view it on GitHub <#348 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4OZC2BIY4G5PQCY37BYS3UZGHOZANCNFSM5NM6XE3Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[jeffalo]

I'm only importing svelte-dnd-action in one component, that's used on a couple pages.

The hididen accessibility divs are added to the document once any page loads, regardless of what page the user is on.

[isaacHagoel]

interesting.
currently it happens in keyboardAction.js (the call to initAria).
It could be modified to a smarter version that only lazy initialises it (if it wasn't already) inside of the dndzone function itself and incremend a counter and have destroy decrement the counter and remove all of the aria elements when the couter hits zero.
would that satisfy your needs?

[jeffalo]

That sounds good to me :)

[isaacHagoel]

@jeffalo do you mind giving it a shot with branch 348-clean-up-aria?
Let me know if it fixed the issue for you

[isaacHagoel]

@jeffalo ping. did u have a chance to test the latest?

[jeffalo]

Hey, apologies for seeing this just now. After running npm run up svelte-dnd-action everything is working perfectly, locally and in production. Thank you so much.

[isaacHagoel]

No worries. Thanks for letting me know

…

On Wed, Feb 23, 2022, 06:11 jeffalo ***@***.***> wrote: Hey, apologies for seeing this just now. After running npm run up svelte-dnd-action everything is working perfectly, locally and in production. Thank you so much. — Reply to this email directly, view it on GitHub <#348 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4OZC52CES5DIWQJDOPC7LU4PNWDANCNFSM5NM6XE3Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>