Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented metrics endpoint #196

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Implemented metrics endpoint #196

merged 7 commits into from
Mar 28, 2024

Conversation

lukas016
Copy link
Contributor

Proposed Changes

  • implement standard prometheus metric server

Fixes #57

@lukas016 lukas016 linked an issue Feb 20, 2024 that may be closed by this pull request
Implement support for metrics server #57
Closed
@lukas016 lukas016 changed the title create own server for exposing of metrics create own http server for exposing of metrics Feb 20, 2024
@lukas016 lukas016 force-pushed the 57-implement-support-for-metrics-server branch from 6e20144 to 1cc3876 Compare February 20, 2024 15:00
@lukas016 lukas016 self-assigned this Feb 20, 2024
@lukas016 lukas016 added the integration-tests to run integration tests label Feb 20, 2024
@lukas016 lukas016 marked this pull request as ready for review February 20, 2024 15:11
@lukas016 lukas016 requested a review from a team as a code owner February 20, 2024 15:11
@lukas016 lukas016 changed the title create own http server for exposing of metrics Create own http server for exposing of metrics Feb 20, 2024
so-sahu
so-sahu reviewed Feb 21, 2024
View reviewed changes
@so-sahu so-sahu mentioned this pull request Feb 26, 2024
Open
@lukas016 lukas016 force-pushed the 57-implement-support-for-metrics-server branch 2 times, most recently from 84ec792 to a665e58 Compare March 4, 2024 08:38
@lukas016 lukas016 mentioned this pull request Mar 6, 2024
Closed
lukas016
lukas016 commented Mar 6, 2024
View reviewed changes
@lukas016 lukas016 requested a review from so-sahu March 6, 2024 09:07
@lukas016 lukas016 requested a review from so-sahu March 8, 2024 10:51
so-sahu
so-sahu requested changes Mar 11, 2024
View reviewed changes
so-sahu
so-sahu requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@so-sahu so-sahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified.

so-sahu
so-sahu previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@so-sahu so-sahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukas016 lukas016 force-pushed the 57-implement-support-for-metrics-server branch from be9519a to 49ecf62 Compare March 15, 2024 07:45
@lukas016 lukas016 requested a review from so-sahu March 15, 2024 09:25
so-sahu
so-sahu previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@so-sahu so-sahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukas016 lukas016 force-pushed the 57-implement-support-for-metrics-server branch from 8d16163 to 728c53d Compare March 19, 2024 12:44
lukasfrank
lukasfrank reviewed Mar 19, 2024
View reviewed changes
@lukas016 lukas016 force-pushed the 57-implement-support-for-metrics-server branch from 728c53d to bc7ab66 Compare March 26, 2024 09:28
@lukas016 lukas016 requested review from so-sahu and lukasfrank March 28, 2024 07:38
@lukasfrank lukasfrank changed the title Create own http server for exposing of metrics Implemented metrics endpoint Mar 28, 2024
@lukasfrank lukasfrank merged commit a22a50d into main Mar 28, 2024
10 checks passed
@lukasfrank lukasfrank deleted the 57-implement-support-for-metrics-server branch March 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasabe28 kasabe28 kasabe28 left review comments

@lukasfrank lukasfrank lukasfrank approved these changes

@so-sahu so-sahu Awaiting requested review from so-sahu

Assignees

@lukas016 lukas016

Labels
integration-tests to run integration tests server size/M
Projects
Compute
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement support for metrics server
4 participants
@lukas016 @lukasfrank @so-sahu @kasabe28