Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Timeouts for GRPC and Streaming Servers #221

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implementing Timeouts for GRPC and Streaming Servers #221

wants to merge 3 commits into from

Conversation

so-sahu
Copy link
Contributor

@so-sahu so-sahu commented Mar 6, 2024

Fixes #205

@so-sahu so-sahu self-assigned this Mar 6, 2024
@so-sahu so-sahu requested a review from a team as a code owner March 6, 2024 05:57
@github-actions github-actions bot added enhancement New feature or request server size/M labels Mar 6, 2024
@so-sahu so-sahu added the integration-tests to run integration tests label Mar 6, 2024
lukas016
lukas016 reviewed Mar 6, 2024
View reviewed changes
provider/cmd/app/app.go
ConnectionTimeout time.Duration
}

type ServersOptions struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will create conflict with #196

lukas016
lukas016 reviewed Mar 6, 2024
View reviewed changes
provider/cmd/app/app.go Outdated Show resolved Hide resolved
lukas016
lukas016 previously approved these changes Mar 6, 2024
View reviewed changes
@so-sahu so-sahu marked this pull request as draft March 13, 2024 10:35
@github-actions github-actions bot added size/L and removed size/M labels Mar 13, 2024
@so-sahu so-sahu force-pushed the enh/implement-timeout-for-servers branch from 493af88 to 452ca53 Compare March 13, 2024 12:37
@so-sahu so-sahu marked this pull request as ready for review March 13, 2024 12:38
@so-sahu so-sahu force-pushed the enh/implement-timeout-for-servers branch from 452ca53 to 7359c6f Compare March 13, 2024 12:42
@so-sahu so-sahu requested a review from lukasfrank March 13, 2024 12:53
lukas016
lukas016 previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@so-sahu so-sahu force-pushed the enh/implement-timeout-for-servers branch from 7359c6f to 72ff16b Compare March 15, 2024 14:58
@so-sahu so-sahu requested a review from lukas016 March 15, 2024 14:59
@so-sahu so-sahu force-pushed the enh/implement-timeout-for-servers branch from 72ff16b to 7e4925c Compare March 19, 2024 10:45
@so-sahu so-sahu force-pushed the enh/implement-timeout-for-servers branch from 7e4925c to 0fbee50 Compare March 20, 2024 05:02
lukas016
lukas016 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas016 lukas016 lukas016 approved these changes

@lukasfrank lukasfrank Awaiting requested review from lukasfrank

Assignees

@so-sahu so-sahu

Labels
enhancement New feature or request integration-tests to run integration tests server size/L
Projects
Compute
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Timeout Settings for gRPC and Streaming Servers
2 participants
@so-sahu @lukas016