Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix e2e matmul generator to extract the input element type. #18140

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[GPU] Fix e2e matmul generator to extract the input element type. #18140

merged 2 commits into from
Aug 7, 2024

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Aug 7, 2024 •
edited
Loading

It is a follow-up for #18134 (comment)

ci-extra: build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4

@hanhanW hanhanW requested review from ScottTodd and pashu123 August 7, 2024 16:51
@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 7, 2024

@ScottTodd is there a way to trigger AMD related CI jobs in presubmit?

pashu123
pashu123 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pashu123 pashu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ScottTodd
Copy link
Member

@ScottTodd is there a way to trigger AMD related CI jobs in presubmit?

Until #18138 is merged, add somethign like ci-extra: build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4 to your PR description

@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 7, 2024

@ScottTodd is there a way to trigger AMD related CI jobs in presubmit?

Until #18138 is merged, add somethign like ci-extra: build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4 to your PR description

I see. I reviewed the code, and I'll rebase on it and test.

@hanhanW hanhanW force-pushed the fix-more-mfma-wmma-changes branch from 9316e29 to 3c7b82a Compare August 7, 2024 16:56
@ScottTodd
Copy link
Member

@ScottTodd is there a way to trigger AMD related CI jobs in presubmit?

Until #18138 is merged, add somethign like ci-extra: build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4 to your PR description

I see. I reviewed the code, and I'll rebase on it and test.

Looks like the tests are queued up now. https://github.com/iree-org/iree/actions/runs/10288503045?pr=18140
image

@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 7, 2024

The MI250 and MI300 CI jobs are happy, so I'm going to land the PR.

image

@ScottTodd
Copy link
Member

Thanks!

@hanhanW hanhanW merged commit 31bfc93 into iree-org:main Aug 7, 2024
43 of 44 checks passed
@hanhanW hanhanW deleted the fix-more-mfma-wmma-changes branch August 7, 2024 18:07
@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 7, 2024

It looks like W7900 job is failing because of this change. I'll take a look after lunch.

https://github.com/iree-org/iree/actions/runs/10289449633/job/28478608054

@hanhanW hanhanW mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashu123 pashu123 pashu123 approved these changes

@ScottTodd ScottTodd Awaiting requested review from ScottTodd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanhanW @ScottTodd @pashu123