-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Updates mfma/wmma attribute names in the matmul test generator. #18134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the follop-up for iree-org@82012e6 iree-org@ef28786 only fixes the mlir files but not python test generator. The revision includes the case. Signed-off-by: hanhanW <[email protected]>
Hopefully this is the last one... I don't see those attributes in the grep commands. |
ScottTodd
approved these changes
Aug 7, 2024
@hanhanW We also need to update
|
Whoops yeah. More updates needed and the relevant test jobs didn't run on this PR. Sent #18138 so PRs like this will run the tests in the future. |
hanhanW
added a commit
to hanhanW/iree
that referenced
this pull request
Aug 7, 2024
It is a follow-up for iree-org#18134 (comment) Signed-off-by: hanhanW <[email protected]>
ScottTodd
added a commit
that referenced
this pull request
Aug 7, 2024
Would have been nice to run tests on #18134, without needing to use the `ci-extra` git trailer.
hanhanW
added a commit
to hanhanW/iree
that referenced
this pull request
Aug 7, 2024
It is a follow-up for iree-org#18134 (comment) Signed-off-by: hanhanW <[email protected]>
hanhanW
added a commit
that referenced
this pull request
Aug 7, 2024
…8140) It is a follow-up for #18134 (comment) ci-extra: build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4 --------- Signed-off-by: hanhanW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follop-up for 82012e6
ef28786 only fixes the mlir files but not python test generator. The revision includes the case.