[Codegen][GPU] Add kernel config for LLVMGPUTileAndFuse for targeting mma #18105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qedawkins
force-pushed
the
mfma_kernel_config
branch
from
2923149 to
aa40e0f
Compare
qedawkins
force-pushed
the
mfma_kernel_config
branch
from
aa40e0f to
0b9028d
Compare
qedawkins
requested review from
antiagainst,
MaheshRavishankar,
kuhar,
Groverkss and
hanhanW
as code owners
Max191
reviewed
Aug 6, 2024
compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.h
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,112 @@ | |||
| // Copyright 2024 The IREE Authors | |||
There was a problem hiding this comment.
Commenting for other reviewers, since it may not be clear. The contents of this file were moved from TargetUtils/ConfigUtils.cpp (which has been replaced with new logic in that file).
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Aug 6, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/ConfigUtils.cpp
Outdated
Show resolved
Hide resolved
This patch adds kernel configuration logic for contraction like operations to use mma instructions with the LLVMGPUTileAndFusePipeline. This directly leverages the configuration logic already present and in use for existing matmul based pipelines, instead generating a config for TileAndFuse.
qedawkins
force-pushed
the
mfma_kernel_config
branch
from
85588aa to
2eed5f5
Compare
Max191
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds kernel configuration logic for contraction like
operations to use mma instructions with the LLVMGPUTileAndFusePipeline.
This directly leverages the configuration logic already present and in
use for existing matmul based pipelines, instead generating a config for
TileAndFuse.