-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codegen][GPU] Add kernel config for LLVMGPUTileAndFuse for targeting mma #18105
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/DerivedConfigUtils.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| // Copyright 2024 The IREE Authors | ||
| // | ||
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #include "iree/compiler/Codegen/Dialect/GPU/IR/DerivedConfigUtils.h" | ||
| #include <numeric> | ||
|
|
||
| #include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.h" | ||
| #include "iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.h" | ||
| #include "mlir/Dialect/Linalg/IR/LinalgInterfaces.h" | ||
| #include "mlir/IR/BuiltinAttributes.h" | ||
| #include "mlir/IR/TypeUtilities.h" | ||
|
|
||
| namespace mlir::iree_compiler::IREE::GPU { | ||
|
|
||
| static constexpr int64_t kPreferredCopyNumBits = 128; | ||
|
|
||
| SmallVector<int64_t> | ||
| getThreadTileSizesFromLoopRanges(SmallVector<int64_t> loopRanges, | ||
| int64_t numThreads, int64_t vectorSize) { | ||
| // TODO: We shouldn't need this check, however loop fusion currently requires | ||
| // loop trip counts to be identical, meaning we need to use a num_threads | ||
| // variant of tiling. Remove this and simply return the preferred vector size | ||
| // once loop fusion can resolve the forall properly. | ||
| if (llvm::any_of(loopRanges, | ||
| [](int64_t s) { return ShapedType::isDynamic(s); })) { | ||
| return {}; | ||
| } | ||
|
|
||
| int64_t flatNumTrips = std::accumulate(loopRanges.begin(), loopRanges.end(), | ||
| 1, std::multiplies<int64_t>()); | ||
| if (flatNumTrips % numThreads != 0) { | ||
| return {}; | ||
| } | ||
| int64_t maxVectorSize = flatNumTrips / numThreads; | ||
|
|
||
| while (maxVectorSize % vectorSize != 0) { | ||
| vectorSize /= 2; | ||
| } | ||
|
|
||
| SmallVector<int64_t> tileSizes(loopRanges.size(), 0); | ||
| tileSizes.back() = vectorSize; | ||
| int64_t residualNumThreads = numThreads / (loopRanges.back() / vectorSize); | ||
| for (int i = tileSizes.size() - 2, e = 0; i >= e; --i) { | ||
| if (loopRanges[i] >= residualNumThreads) { | ||
| tileSizes[i] = loopRanges[i] / residualNumThreads; | ||
| residualNumThreads = 1; | ||
| break; | ||
| } | ||
| tileSizes[i] = 1; | ||
| residualNumThreads /= loopRanges[i]; | ||
| } | ||
|
|
||
| return tileSizes; | ||
| } | ||
|
|
||
| SmallVector<int64_t> deriveLinalgOpThreadTileSizes(linalg::LinalgOp linalgOp, | ||
| int64_t numThreads) { | ||
| if (!linalgOp.hasPureTensorSemantics()) { | ||
| return {}; | ||
| } | ||
| // TODO: Support multi-result | ||
| if (linalgOp->getNumResults() != 1) { | ||
| return {}; | ||
| } | ||
| SmallVector<int64_t> loopRanges = linalgOp.getStaticLoopRanges(); | ||
| int64_t vectorSize = kPreferredCopyNumBits / | ||
| getElementTypeOrSelf(linalgOp->getResultTypes()[0]) | ||
| .getIntOrFloatBitWidth(); | ||
| return getThreadTileSizesFromLoopRanges(loopRanges, numThreads, vectorSize); | ||
| } | ||
|
|
||
| SmallVector<int64_t> | ||
| deriveIm2colOpThreadTileSizes(IREE::LinalgExt::Im2colOp im2colOp, | ||
| int64_t numThreads) { | ||
| if (!im2colOp.hasPureTensorSemantics()) { | ||
| return {}; | ||
| } | ||
| // TODO(Max191): Add `getStaticLoopRanges` to TilingInterface, and use it | ||
| // here instead of `im2colOp.getOutputType().getShape()`. Then we can also | ||
| // get rid of the specialization for Im2colOp vs LinalgOp and just use | ||
| // TilingInterface ops. | ||
| SmallVector<int64_t> loopRanges(im2colOp.getOutputType().getShape()); | ||
| int64_t vectorSize = kPreferredCopyNumBits / | ||
| getElementTypeOrSelf(im2colOp->getResultTypes()[0]) | ||
| .getIntOrFloatBitWidth(); | ||
| return getThreadTileSizesFromLoopRanges(loopRanges, numThreads, vectorSize); | ||
| } | ||
|
|
||
| SmallVector<int64_t> deriveThreadTileSizes(Operation *op) { | ||
| std::optional<SmallVector<int64_t>> workgroupSize = | ||
| getWorkgroupSize(op->getParentOfType<FunctionOpInterface>()); | ||
| if (!workgroupSize) { | ||
| return {}; | ||
| } | ||
| int64_t numThreads = | ||
| std::accumulate(workgroupSize->begin(), workgroupSize->end(), 1, | ||
| std::multiplies<int64_t>()); | ||
| return TypeSwitch<Operation *, SmallVector<int64_t>>(op) | ||
| .Case([&](linalg::LinalgOp linalgOp) -> SmallVector<int64_t> { | ||
| return deriveLinalgOpThreadTileSizes(linalgOp, numThreads); | ||
| }) | ||
| .Case([&](IREE::LinalgExt::Im2colOp im2colOp) -> SmallVector<int64_t> { | ||
| return deriveIm2colOpThreadTileSizes(im2colOp, numThreads); | ||
| }) | ||
| .Default([](Operation *op) -> SmallVector<int64_t> { return {}; }); | ||
| } | ||
|
|
||
| } // namespace mlir::iree_compiler::IREE::GPU | ||
18 changes: 18 additions & 0 deletions
18
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/DerivedConfigUtils.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Copyright 2024 The IREE Authors | ||
| // | ||
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef IREE_COMPILER_CODEGEN_DIALECT_GPU_IR_DERIVEDCONFIGUTILS_H_ | ||
| #define IREE_COMPILER_CODEGEN_DIALECT_GPU_IR_DERIVEDCONFIGUTILS_H_ | ||
|
|
||
| #include "mlir/IR/Operation.h" | ||
|
|
||
| namespace mlir::iree_compiler::IREE::GPU { | ||
|
|
||
| SmallVector<int64_t> deriveThreadTileSizes(Operation *op); | ||
|
|
||
| } // namespace mlir::iree_compiler::IREE::GPU | ||
|
|
||
| #endif // IREE_COMPILER_CODEGEN_DIALECT_GPU_IR_DERIVEDCONFIGUTILS_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting for other reviewers, since it may not be clear. The contents of this file were moved from
TargetUtils/ConfigUtils.cpp(which has been replaced with new logic in that file).