Install and use clang in GPU test jobs. #18076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Jul 31, 2024
Also updated step names for consistency.
ScottTodd
force-pushed
the
infra-pkgci-clang
branch
from
f4c9703 to
252c015
Compare
|
Ping? |
saienduri
reviewed
Aug 5, 2024
| @@ -30,11 +30,11 @@ jobs: | |||
| IREE_HIP_DISABLE: 0 | |||
| IREE_HIP_TEST_TARGET_CHIP: "gfx90a" | |||
There was a problem hiding this comment.
You can also add environment variables that you want to use here in the future
ScottTodd
added a commit
that referenced
this pull request
Aug 6, 2024
This fixes the nightly 'samples' workflow. I thought this `libstdc++-12-dev` dep would help use clang instead of gcc here: #18076. Turns out that package doesn't exist on ubuntu-20.04: https://github.com/iree-org/iree/actions/runs/10260247034/job/28385997161#step:4:43 `E: Unable to locate package libstdc++-12-dev`. A working clang toolchain also already exists. Ugh Linux. Tested here: https://github.com/ScottTodd/iree/actions/runs/10269229609. (Yes, we could use Docker to manage toolchains / system deps like this, but I'd really rather not) skip-ci: no impact on regular workflows (and soon this won't trigger them at all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this when setting up these AMD jobs / migrating the NVIDIA job away from Docker. The jobs had been using gcc :P
ci-exactly: build_packages, test_amd_mi250, test_amd_mi300, test_amd_w7900, test_nvidia_t4