Skip to content

Commit

Permalink
Install and use clang in GPU test jobs. (#18076)
Browse files Browse the repository at this point in the history
Missed this when setting up these AMD jobs / migrating the NVIDIA job
away from Docker. The jobs had been using gcc :P

ci-exactly: build_packages, test_amd_mi250, test_amd_mi300,
test_amd_w7900, test_nvidia_t4
  • Loading branch information
ScottTodd authored Aug 5, 2024
1 parent 2193406 commit 09dc003
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 26 deletions.
15 changes: 11 additions & 4 deletions .github/workflows/pkgci_test_amd_mi250.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ jobs:
IREE_HIP_DISABLE: 0
IREE_HIP_TEST_TARGET_CHIP: "gfx90a"
steps:
- name: Checking out repository
- name: Check out repository
uses: actions/[email protected]
with:
submodules: false
- name: "Checking out runtime submodules"
- name: Check out runtime submodules
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- uses: actions/[email protected]
with:
Expand All @@ -49,9 +49,16 @@ jobs:
./build_tools/pkgci/setup_venv.py ${VENV_DIR} \
--artifact-path=${PACKAGE_DOWNLOAD_DIR} \
--fetch-gh-workflow=${{ inputs.artifact_run_id }}
- name: "Building tests"
- name: Install build dependencies
run: |
sudo apt update
sudo apt install -y cmake clang ninja-build libstdc++-12-dev
echo "CC=clang" >> $GITHUB_ENV
echo "CXX=clang++" >> $GITHUB_ENV
- name: Build tests
run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin
- name: "Running GPU tests"
- name: Run GPU tests
env:
CTEST_PARALLEL_LEVEL: 2
IREE_CTEST_LABEL_REGEX: ^requires-gpu|^driver=hip$
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/pkgci_test_amd_mi300.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ jobs:
if: contains(matrix.name, 'gfx942')
run: |
sudo chmod -R 777 ~/actions-runner/_work
- name: Checking out repository
- name: Check out repository
uses: actions/[email protected]
with:
submodules: false
- name: "Checking out runtime submodules"
- name: Check out runtime submodules
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- uses: actions/[email protected]
with:
Expand All @@ -54,9 +54,16 @@ jobs:
./build_tools/pkgci/setup_venv.py ${VENV_DIR} \
--artifact-path=${PACKAGE_DOWNLOAD_DIR} \
--fetch-gh-workflow=${{ inputs.artifact_run_id }}
- name: "Building tests"
- name: Install build dependencies
run: |
sudo apt update
sudo apt install -y cmake clang ninja-build libstdc++-12-dev
echo "CC=clang" >> $GITHUB_ENV
echo "CXX=clang++" >> $GITHUB_ENV
- name: Build tests
run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin
- name: "Running GPU tests"
- name: Run GPU tests
env:
CTEST_PARALLEL_LEVEL: 2
IREE_CTEST_LABEL_REGEX: ^requires-gpu|^driver=hip$
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/pkgci_test_amd_w7900.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ jobs:
IREE_HIP_DISABLE: 0
IREE_HIP_TEST_TARGET_CHIP: "gfx1100"
steps:
- name: Checking out repository
- name: Check out repository
uses: actions/[email protected]
with:
submodules: false
- name: "Checking out runtime submodules"
- name: Check out runtime submodules
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- uses: actions/[email protected]
with:
Expand All @@ -49,9 +49,10 @@ jobs:
./build_tools/pkgci/setup_venv.py ${VENV_DIR} \
--artifact-path=${PACKAGE_DOWNLOAD_DIR} \
--fetch-gh-workflow=${{ inputs.artifact_run_id }}
- name: "Building tests"
- name: Build tests
run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin
- name: "Running GPU tests"
- name: Run GPU tests
env:
CTEST_PARALLEL_LEVEL: 1
IREE_CTEST_LABEL_REGEX: ^requires-gpu|^driver=vulkan$|^driver=hip$
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/pkgci_test_nvidia_t4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,13 @@ jobs:
IREE_CUDA_DISABLE: 0
IREE_HIP_DISABLE: 1
steps:
- name: Checking out repository
- name: Check out repository
uses: actions/[email protected]
with:
submodules: false
- name: "Checking out runtime submodules"
- name: Check out runtime submodules
run: ./build_tools/scripts/git/update_runtime_submodules.sh
- name: Install dependencies
run: |
sudo apt update
sudo apt install -y cmake clang ninja-build
export CC=clang
export CXX=clang
- name: Querying GPU information
- name: Query GPU information
run: |
./build_tools/scripts/check_cuda.sh
./build_tools/scripts/check_vulkan.sh
Expand All @@ -63,9 +57,16 @@ jobs:
./build_tools/pkgci/setup_venv.py ${VENV_DIR} \
--artifact-path=${PACKAGE_DOWNLOAD_DIR} \
--fetch-gh-workflow=${{ inputs.artifact_run_id }}
- name: "Building tests"
- name: Install build dependencies
run: |
sudo apt update
sudo apt install -y cmake clang ninja-build libstdc++-12-dev
echo "CC=clang" >> $GITHUB_ENV
echo "CXX=clang++" >> $GITHUB_ENV
- name: Build tests
run: ./build_tools/pkgci/build_tests_using_package.sh ${VENV_DIR}/bin
- name: "Running GPU tests"
- name: Run GPU tests
env:
CTEST_PARALLEL_LEVEL: 2
IREE_CTEST_LABEL_REGEX: ^requires-gpu|^driver=vulkan$|^driver=cuda$
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/samples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ jobs:
- name: "Installing build dependencies"
run: |
sudo apt update
sudo apt install cmake clang ninja-build
export CC=clang
export CXX=clang++
sudo apt install -y cmake clang ninja-build libstdc++-12-dev
echo "CC=clang" >> $GITHUB_ENV
echo "CXX=clang++" >> $GITHUB_ENV
- name: "Setting up Python"
uses: actions/[email protected]
with:
Expand Down

0 comments on commit 09dc003

Please sign in to comment.