Drop python_release_packages CI job in favor of pkgci.
#17958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
infrastructure
ScottTodd
commented
Jul 19, 2024
Comment on lines
+59
to
+60
| echo "Testing compiler package:" | ||
| python -m iree.compiler._package_test |
There was a problem hiding this comment.
https://github.com/iree-org/iree/actions/runs/10012117284/job/27677738230#step:7:22
Not checking iree-import-onnx: onnx pip package not found
Dropping sanity check coverage for iree-import-onnx here, since build_tools/pkgci_setup_venv.py doesn't install it. Could maybe install it here
Anyways, #16624 tracks getting more tests for iree-import-onnx running
|
Ping? This will help reduce the load on CPU presubmit builders. |
benvanik
approved these changes
Jul 24, 2024
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
) Fixes iree-org#17955. ~~This puts the "validate wheels" step right in the build job, when it could be moved to a separate job. I figure that any following jobs should be able to trust that the wheels pass basic validation, though this does add 20 seconds to the front of the pipeline.~~ ^ Nevermind, just added a new job. The way the wheels are built/uploaded/downloaded was a bit tricky to parse through and this keeps the flow compartmentalized. ci-exactly: build_packages, unit_test Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17955.
This puts the "validate wheels" step right in the build job, when it could be moved to a separate job. I figure that any following jobs should be able to trust that the wheels pass basic validation, though this does add 20 seconds to the front of the pipeline.^ Nevermind, just added a new job. The way the wheels are built/uploaded/downloaded was a bit tricky to parse through and this keeps the flow compartmentalized.
ci-exactly: build_packages, unit_test