Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'python_release_packages' job from ci.yml #17955

Closed
ScottTodd opened this issue Jul 18, 2024 · 0 comments · Fixed by #17958
Closed

Remove 'python_release_packages' job from ci.yml #17955

ScottTodd opened this issue Jul 18, 2024 · 0 comments · Fixed by #17958
Assignees
Labels
bindings/python Python wrapping IREE's C API cleanup 🧹 infrastructure Relating to build systems, CI, or testing

Comments

@ScottTodd
Copy link
Member

ScottTodd commented Jul 18, 2024

The 'python_release_packages' job in ci.yml is mostly redundant with pkgci_build_packages.yml. We should add any missing coverage (e.g. running python -m iree.runtime._package_test and python -m iree.compiler._package_test) to pkgci and remove the job from ci.yml.

Sample logs:

@ScottTodd ScottTodd added infrastructure Relating to build systems, CI, or testing bindings/python Python wrapping IREE's C API cleanup 🧹 labels Jul 18, 2024
@ScottTodd ScottTodd self-assigned this Jul 18, 2024
LLITCHEV pushed a commit to LLITCHEV/iree that referenced this issue Jul 30, 2024
)

Fixes iree-org#17955.

~~This puts the "validate wheels" step right in the build job, when it
could be moved to a separate job. I figure that any following jobs
should be able to trust that the wheels pass basic validation, though
this does add 20 seconds to the front of the pipeline.~~
^ Nevermind, just added a new job. The way the wheels are
built/uploaded/downloaded was a bit tricky to parse through and this
keeps the flow compartmentalized.

ci-exactly: build_packages, unit_test
Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/python Python wrapping IREE's C API cleanup 🧹 infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant