Revert "Revert "[LLVMGPU][ROCm] Add MFMA_F32_16x16x4_F32 instruction"… #17921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iree-org#17894)" This reverts commit 02c2000.
pashu123
force-pushed
the
wmma_rebased
branch
2 times, most recently
from
836a821 to
2ee6d68
Compare
pashu123
requested review from
kuhar,
qedawkins,
MaheshRavishankar and
antiagainst
as code owners
raikonenfnu
reviewed
Jul 23, 2024
| // TODO: Generalize to other dimensions. | ||
| // Try to search for pad value and check only filter dimension is blocked. | ||
| SmallVector<std::array<int64_t, 3>> mnkPaddingCandidates; | ||
| for (const GPUMatmulShapeType &intrinsic : intrinsics) { | ||
|
|
||
| if (inpElemType != intrinsic.aType && kernelElemType != intrinsic.bType) { |
There was a problem hiding this comment.
I think this should be || no? because if either of this is not true then we want to skip.
There was a problem hiding this comment.
Yes, thanks for correcting.
| if lhs_rhs_type.value.upper() not in schedule.intrinsic: | ||
| # Search for the lhs_rhs type in the first part of intrinsic | ||
| # e.g., MFMA_F32_16x16x4_F32 -> MFMA_F32 | ||
| if lhs_rhs_type.value.upper() not in schedule.intrinsic[:8]: |
There was a problem hiding this comment.
Would this work with MFMA_F8E4M3FNUZ intrinsic?
There was a problem hiding this comment.
The current logic won't. I've updated the script to find the right pattern. PTAL.
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
iree-org#17921) … (iree-org#17894)" This reverts commit 02c2000. Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#17894)"
This reverts commit 02c2000.