-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[LLVMGPU][ROCm] Add MFMA_F32_16x16x4_F32 instruction" #17894
Conversation
This reverts commit d65c6d4.
Going to see if I can get logs locally while the CI sanity check runs on this. |
Hmm... seems like compilation succeeded but benchmarking failed. Possibly a runtime error from the driver if unsupported instructions were included or something. I don't have an easy way to check right now. |
@ScottTodd Do you have instruction to repro this? |
The logs should (ideally) provide enough info: https://github.com/iree-org/iree/actions/runs/9911235296/job/27383808262#step:16:46
Source files might be split between https://github.com/nod-ai/SHARK-TestSuite/tree/4486c44a3d9e61dd20317fe1d23be71ff1610f32/iree_tests/benchmarks/sdxl and https://github.com/nod-ai/SHARK-TestSuite/tree/4486c44a3d9e61dd20317fe1d23be71ff1610f32/iree_tests/pytorch/models |
I was also planning on fixing the script to print the right error logs and then getting a CI run with that PR again to check that logs appear. |
…iree-org#17894)" This reverts commit 02c2000.
Trying to get more info with #17907 |
https://github.com/iree-org/iree/actions/runs/9944277339/job/27470515222?pr=17907#step:7:171
|
…ruction" (iree-org#17894)"" This reverts commit 13c11b7. (We must go deeper)
…iree-org#17894)" This reverts commit 02c2000.
…iree-org#17894)" This reverts commit 02c2000.
…rg#17894) Reverts iree-org#17847 This broke SDXL rocm pipeline tests on mi300, see iree-org#17847 (comment). The tests aren't showing error messages (`root:benchmark_sdxl_rocm.py:31 Command failed with error: b''`) so I can't easily tell what the issue is, nod-ai/SHARK-TestSuite#286 is filed to improve the situation there. Signed-off-by: Lubo Litchev <[email protected]>
iree-org#17921) … (iree-org#17894)" This reverts commit 02c2000. Signed-off-by: Lubo Litchev <[email protected]>
Reverts #17847
This broke SDXL rocm pipeline tests on mi300, see #17847 (comment). The tests aren't showing error messages (
root:benchmark_sdxl_rocm.py:31 Command failed with error: b''
) so I can't easily tell what the issue is, nod-ai/SHARK-TestSuite#286 is filed to improve the situation there.