Refactor convolution test suite #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Sep 10, 2024
erman-gurses
force-pushed
the
add-conv-test-suite
branch
from
2494de4 to
d8f70a1
Compare
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
force-pushed
the
add-conv-test-suite
branch
from
1523ab5 to
fc08f82
Compare
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
|
@ScottTodd, the CPU part is done. Let me know if you have any input. |
ScottTodd
reviewed
Oct 21, 2024
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
ScottTodd
reviewed
Oct 22, 2024
linalg_ops/convolution/generated/f16_f16_f16/conv2d_f16_f16_f16_medium_calls.mlir
Outdated
Show resolved
Hide resolved
linalg_ops/convolution/generated/f16_f16_f16/conv2d_f16_f16_f16_medium.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
pashu123
reviewed
Oct 24, 2024
linalg_ops/convolution/generated/f16_f16_f16/conv2d_f16_f16_f16_large.mlir
Outdated
Show resolved
Hide resolved
ScottTodd
approved these changes
Oct 24, 2024
Max191
requested changes
Oct 24, 2024
There was a problem hiding this comment.
The formats for CPU tests and GPU tests are quite different, but they should be able to use the same source IR. Can we consolidate the test generation into a single format to reduce the number of generated tests?
It would be good to cover the following element type and layout combinations on both CPU and GPU to start:
- Both NCHW and NHWC convs for all the following dtype combinations:
- f16_f16_f16 (with and without winograd)
- f32_f32_f32 (with and without winograd)
- f16_f16_f32 (with and without winograd)
- i8_i8_i32 (without winograd)
EDIT: Btw, I don't mean to block progress if this is just an initial step, but if we are merging these tests, then we should try to share the implementation. If you would prefer to do this as a follow up that is also okay.
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
force-pushed
the
add-conv-test-suite
branch
from
595f8ec to
bb4257b
Compare
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #2.
This PR refactors, adds, and migrates conv2d e2e tests from the PRs here: iree-org/iree#16849 and iree-org/iree#18125