fix: recover from missing window.crypto #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix that detects failure due to missing window.crypto.subtle and redirects to a canonical URL that is known to work in all browsers, even when IPFS Companion is enabled in Firefox License: MIT Signed-off-by: Marcin Rataj <[email protected]>
jessicaschilling
approved these changes
May 27, 2020
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
May 28, 2020
Firefox exposes full URL of a parent page in request.originUrl, which enables us to respect redirecti opt-out not only for the parent request, but also subresources. This is necessary for ipld/explore.ipld.io#60 to work in Firefox.
This was referenced Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix that detects js-ipfs init failure due to missing
window.crypto.subtleand redirects to a canonical URL that is known to work in all browsers.I also removed dead code responsible for
window.ipfsThe goal here is to improve UX in Firefox with IPFS Companion until https://bugzilla.mozilla.org/show_bug.cgi?id=1220810 is fixed upstream.