Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Error: invalid argument" with window.ipfs #43

Closed
lidel opened this issue Nov 17, 2018 · 1 comment
Closed

"Error: invalid argument" with window.ipfs #43

lidel opened this issue Nov 17, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Collaborator

lidel commented Nov 17, 2018 •
edited
Loading

Problem

An incarnation of the problem from ipfs/ipfs-webui#874 manifests on explore.ipld.io when used with window.ipfs:

  • with DNSLink

    2018-11-17--17-57-35

  • without DNSLink

    2018-11-17--18-08-46

How to Fix

@olizilla in spare moment, review and merge ipfs/ipld-explorer-components#7, then release new ipld-explorer-components and switch this repo to the new version and merge to maste, so Jenkinds rebuilds the explore.ipld.io with the new cids lib.
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Nov 17, 2018
@lidel
Copy link
Collaborator Author

lidel commented Jun 4, 2020

Fixed in #60 – 785e397#diff-964f608593ad5b93325a8122ac4b0c07R52

@lidel lidel closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel