coreapi: extract interface #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
ghost
assigned License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
|
That will be annoyingly long import name, we didn't think about it while deciding on naming scheme. |
|
My only comment is that the repo name doesn't match the go naming convention (would otherwise be go-ipfs-interface-core). But don't really mind either way. |
|
The naming is to match ipfs-inactive/interface-js-ipfs-core#423 (comment) |
|
I'm not going to bikeshed this too much but I've pinged david to try to get his rational. I do like being able to run shell commands over |
Stebalien
approved these changes
Feb 11, 2019
|
We can quibble over naming later. |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
coreapi: extract interface This commit was moved from ipfs/kubo@f6f9cf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now lives in https://github.com/ipfs/interface-go-ipfs-core