-
Notifications
You must be signed in to change notification settings - Fork 124
Consider per-language core-interface repos #423
Comments
I tend to agree. It may make sense to have a single repo for interface design/documentation but having multiple implementations in a single repo seems a bit odd. |
+1 |
Sounds good to me. Can we do instead
|
Seems that we have consensus. Wanna take this on? Pinging @vasco-santos @jacobheun to update the libp2p ones as well (note, we can keep the package name) |
So |
|
@daviddias just to clarify, the goal is to have, for example, |
In response to #423 License: MIT Signed-off-by: Alan Shaw <[email protected]>
Repo renamed and PR here for moving stuff in |
@daviddias any reason to do |
I'm ok with that also, in fact I think I prefer it - so it would be |
Yes but @daviddias asked for the current naming scheme so I'd like to get his reasoning before we rename again. |
We've been using |
Tidy up the API docs by removing refs to Go as well as JavaScript (since this is the JS interface repo). refs #423 refs #435 License: MIT Signed-off-by: Alan Shaw <[email protected]>
Tidy up the API docs by removing refs to Go as well as JavaScript (since this is the JS interface repo). refs #423 refs #435 License: MIT Signed-off-by: Alan Shaw <[email protected]>
Shall we close this? https://github.com/ipfs/interface-go-ipfs-core exists now. |
Go implementation of core-interface (CoreAPI) is getting to the stage where it can be extracted from go-ipfs repo, and afaik it's supposed to live it this repo together with js interface definitions / tests.
But there are problems:
package.json
package.json
to live in repository root (things like gx-workspace, our Jenkins pipelines)I'd say that this repo should stay focused on JS, and interface repos should be called
[lang]-ipfs-interface
@alanshaw @Stebalien @daviddias (+others) Thoughts?
The text was updated successfully, but these errors were encountered: