rewrite FindProvidersAsync #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| provs := dht.providers.GetProviders(ctx, key) | ||
| for _, p := range provs { | ||
| count-- | ||
| // NOTE: assuming that this list of peers is unique |
There was a problem hiding this comment.
what if this assumption isn't true? could it make it hang?
There was a problem hiding this comment.
Nah, it wont hang, we just might send a request to the same peer twice. But im very certain that GetProviders from our provider manager returns a unique list.
There was a problem hiding this comment.
easy to do the ps.Contains check here too.
There was a problem hiding this comment.
that it is... i think not doing that is a result of my shitty-programmer-copy-paste-itis
|
some comments, otherwise lgtm |
|
Addressed comments, will merge when tests finish |
whyrusleeping
added a commit
that referenced
this pull request
Dec 11, 2014
rewrite FindProvidersAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a better
FindProvidersAsynccall that uses the query framework and actually takes advantage of closer peers.