FindProviders regression

[btc]

#440 introduces a bug in the DHT that causes the following test to fail:

1. create network with one bootstrap peer
2. connect a server. connect a client
3. let server add file (client waits for signal to add file)
4. let client cat file

Test fails with output:

client: dht: �FindProviders Query error: routing: not found �routing.go:206�

The failing test is shown here: https://build.protocol-dev.com/job/ipfs-dockertest/9/console

After reverting the changes, the tests pass. The passing test is shown here: https://build.protocol-dev.com/job/ipfs-dockertest/11/console

The branch with the reverted code is here: https://github.com/jbenet/go-ipfs/tree/revert/dht

@whyrusleeping @jbenet Plan of action?

[whyrusleeping]

Thats odd, the new find providers only extends the previous behaviour, before it would just send the peers we had locally in our routing table, now it will do that, then search for more.

Ill take a look at it now

[whyrusleeping]

Do you have any reproductible test case that doesnt involve docker?

[whyrusleeping]

ooooh, wait. I think i see it. We are treating an error on an individual request as an error on the whole RPC

[whyrusleeping]

@maybebtc has this been resolved? Or are you still encountering the same issue?

[btc]

I haven't been able to reproduce the issue. Tests are passing.

[whyrusleeping]

well, if thats the case, ill close this one out.

[btc]

this may have reared its head:

https://build.protocol-dev.com/job/network-test/237/console
https://build.protocol-dev.com/job/gotest/329/console

cc @jbenet @whyrusleeping

[whyrusleeping]

If needed, I can shift my focus over to getting the DHT into a workable state.

[btc]

@jbenet @whyrusleeping it's becoming increasingly likely that this is causing failures on #463

[jbenet]

@maybebtc hm. probably :(

[jbenet]

I think this is fixed. @briantigerchow confirm?