Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

per-peer stats #166

Merged
merged 2 commits into from
Feb 6, 2018
Merged

per-peer stats #166

merged 2 commits into from
Feb 6, 2018

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Feb 2, 2018 •
edited
Loading

Addresses #165

  • Starting off by documenting current stats API
  • Stats by peer

@ghost ghost assigned pgte Feb 2, 2018
@ghost ghost added the status/in-progress In progress label Feb 2, 2018
@pgte pgte changed the title WIP: per-peer stats per-peer stats Feb 5, 2018
@pgte
Copy link
Contributor Author

pgte commented Feb 5, 2018

I think this is all ready to review.
I'm not including the per-protocol stats because, according to #165, the per-protocol stats are only viewable at the global level, not at bitswap.

@pgte pgte requested a review from daviddias February 5, 2018 21:58
daviddias
daviddias approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any idea why Circle CI is failing?

@pgte
Copy link
Contributor Author

pgte commented Feb 6, 2018 •
edited
Loading

@diasdavid it's the infamous "Multiplexer destroyed" error, which I think happens on shutdown.

I've created #167 to address this.

@daviddias
Copy link
Member

Ack. Let's move ahead then and figure out that one in parallel.

@daviddias daviddias merged commit ff978d0 into master Feb 6, 2018
@ghost ghost removed the status/in-progress In progress label Feb 6, 2018
@daviddias daviddias deleted the feat/peer-stats branch February 6, 2018 10:21
@daviddias daviddias mentioned this pull request Feb 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgte @daviddias