Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-peer stats #165

Closed
pgte opened this issue Feb 1, 2018 · 8 comments
Closed

per-peer stats #165

pgte opened this issue Feb 1, 2018 · 8 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@pgte
Copy link
Contributor

pgte commented Feb 1, 2018

We need these stats per peer because of ipfs-inactive/dynamic-data-and-capabilities#3 and ipfs/js-ipfs#1198.

@hacdias
Copy link
Member

hacdias commented Feb 1, 2018

For ipfs/js-ipfs#1198, I'll need per-peer and per-protocol stats, of, at least total bandwidth in and total bandwidth out.

@pgte pgte mentioned this issue Feb 2, 2018
2 tasks
@pgte
Copy link
Contributor Author

pgte commented Feb 3, 2018

@hacdias can you define what you mean by "protocol"? Is it the bitswap protocol (1.0.0 or 1.1.0), the transport being used or the multiplexed protocol (DHT, bitswap, etc)?

(If it's the latest, we can't do this at the bitswap level).

@hacdias
Copy link
Member

hacdias commented Feb 3, 2018

@pgte protocol is the transport being used. Just opened an issue on libp2p: libp2p/js-libp2p#157

@daviddias
Copy link
Member

done with #166 , thanks @pgte :)

@hacdias anything else?

@hacdias
Copy link
Member

hacdias commented Feb 6, 2018

@diasdavid what I really need to implement the Bandwidth Stats on js-ipfs is libp2p/js-libp2p#157 because it should measure all of the in and out bandwidth and not only bitswap.

@daviddias daviddias added status/ready Ready to be worked help wanted Seeking public contribution on this issue exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up labels Feb 12, 2018
@bvand
Copy link

bvand commented Mar 21, 2018

@hacdias I'm new to ipfs, looking to help out on an issue like this to get started.

I was looking at ipfs/js-ipfs#1198 - just to confirm my understanding, Bandwidth stats are the only additional per-peer stats left to implement?
What is the current status? Is this something that it would make sense for me to jump on?

@bvand
Copy link

bvand commented Mar 22, 2018

Found ipfs/js-ipfs#1230 - looks like this is complete then? Or is there more?

@hacdias
Copy link
Member

hacdias commented Mar 22, 2018

Oh yes, this one is already done. Thanks @bvand

@hacdias hacdias closed this as completed Mar 22, 2018
@ghost ghost removed the status/ready Ready to be worked label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

4 participants