Skip to content

Commit

Permalink
closes #353
Browse files Browse the repository at this point in the history
  • Loading branch information
rafapereirabr committed Nov 23, 2023
1 parent a022f1d commit f7dd1ae
Show file tree
Hide file tree
Showing 8 changed files with 111 additions and 73 deletions.
2 changes: 2 additions & 0 deletions r-package/NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
**Minor changes**

- In the `accessibility()` function, the value of `max_trip_duration` is now capped by the max value passed to the `cutoffs` parameter. Closes [#342](https://github.com/ipeaGIT/r5r/issues/348).
- Updated documentation of parameter `max_walk_time` to make it clear that in walk-only trips, whenever `max_walk_time` differs from `max_trip_duration`, the lowest value is considered. Closes [#353](https://github.com/ipeaGIT/r5r/issues/353)
- Updated documentation of parameter `max_bike_time` to make it clear that in bicycle-only trips, whenever `max_bike_time` differs from `max_trip_duration`, the lowest value is considered. Closes [#353](https://github.com/ipeaGIT/r5r/issues/353)


# r5r 1.1.0
Expand Down
30 changes: 18 additions & 12 deletions r-package/man/accessibility.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 18 additions & 12 deletions r-package/man/detailed_itineraries.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 18 additions & 12 deletions r-package/man/expanded_travel_time_matrix.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 18 additions & 12 deletions r-package/man/pareto_frontier.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion r-package/man/r5r.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 18 additions & 12 deletions r-package/man/roxygen/templates/common_arguments.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,25 @@
#' for valid dates. Please see details for further information on how
#' datetimes are parsed.
#' @param max_walk_time An integer. The maximum walking time (in minutes) to
#' access and egress the transit network, or to make transfers within the
#' network. Defaults to no restrictions, as long as `max_trip_duration` is
#' respected. The max time is considered separately for each leg (e.g. if
#' you set `max_walk_time` to 15, you could potentially walk up to 15 minutes
#' to reach transit, and up to _another_ 15 minutes to reach the destination
#' after leaving transit). Defaults to `Inf`, no limit.
#' access and egress the transit network, to make transfers within the network
#' or to complete walk-only trips. Defaults to no restrictions (numeric value
#' of `Inf`), as long as `max_trip_duration` is respected. When routing
#' transit trips, the max time is considered separately for each leg (e.g. if
#' you set `max_walk_time` to 15, you could get trips with an up to 15 minutes
#' walk leg to reach transit and another up to 15 minutes walk leg to reach
#' the destination after leaving transit. In walk-only trips, whenever
#' `max_walk_time` differs from `max_trip_duration`, the lowest value is
#' considered.
#' @param max_bike_time An integer. The maximum cycling time (in minutes) to
#' access and egress the transit network. Defaults to no restrictions, as long
#' as `max_trip_duration` is respected. The max time is considered separately
#' for each leg (e.g. if you set `max_bike_time` to 15 minutes, you could
#' potentially cycle up to 15 minutes to reach transit, and up to _another_ 15
#' minutes to reach the destination after leaving transit). Defaults to `Inf`,
#' no limit.
#' access and egress the transit network, to make transfers within the network
#' or to complete bicycle-only trips. Defaults to no restrictions (numeric
#' value of `Inf`), as long as `max_trip_duration` is respected. When routing
#' transit trips, the max time is considered separately for each leg (e.g. if
#' you set `max_bike_time` to 15, you could get trips with an up to 15 minutes
#' cycle leg to reach transit and another up to 15 minutes cycle leg to reach
#' the destination after leaving transit. In bicycle-only trips, whenever
#' `max_bike_time` differs from `max_trip_duration`, the lowest value is
#' considered.
#' @param max_car_time An integer. The maximum driving time (in minutes) to
#' access and egress the transit network. Defaults to no restrictions, as long
#' as `max_trip_duration` is respected. The max time is considered separately
Expand Down
30 changes: 18 additions & 12 deletions r-package/man/travel_time_matrix.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f7dd1ae

Please sign in to comment.