Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cob_kinematics] remove? #72

Closed
fmessmer opened this issue Apr 5, 2016 · 9 comments
Closed

[cob_kinematics] remove? #72

fmessmer opened this issue Apr 5, 2016 · 9 comments

Comments

@fmessmer
Copy link
Member

fmessmer commented Apr 5, 2016

@ipa-mdl
Is there anything about cob_kinematics package that is worth to be kept?

@mathias-luedtke
Copy link
Contributor

Is there a reason to delete it?
It features a urdf2openrave converter.

@fmessmer
Copy link
Member Author

fmessmer commented Apr 5, 2016

I wasn't aware of that....maybe we should put that somewhere more prominent then!
Would this be helpful for generating COLLADA models for e.g. SDHX gripper in order to generate grasps with cob_grasp_generation (see #70)?

@fmessmer
Copy link
Member Author

fmessmer commented Apr 5, 2016

However, we do not compile it (https://github.com/ipa320/cob_manipulation/blob/indigo_dev/cob_kinematics/CMakeLists.txt#L22)
Does it still compile?

@fmessmer
Copy link
Member Author

fmessmer commented Apr 9, 2016

@ipa-mdl
Is the converter related or derived from any of these:

@mathias-luedtke
Copy link
Contributor

No, its unrelated.
However, https://github.com/personalrobotics/or_urdf seems to cover much more aspects..
My implementation just reads an URDF and outputs an OpenRAVE XML (http://openrave.programmingvision.com/wiki/index.php/Format:XML) with the kinematic structure.

@mathias-luedtke
Copy link
Contributor

mathias-luedtke commented Feb 15, 2017

I just noticed that it does not have any install tags..

@fmessmer
Copy link
Member Author

There is a ìkfast_kinematics_plugin in moveit_kinematics and a Tutorial here

IKFast requires OpenRAVE (it seems to be relying on version 0.8) which has to be installed manually anyway (no rosdep entry)

@ipa-mdl
Do you think it is worth keeping this package then?
The yaml's in the config are out of date....although the generated cpp-files still might be usable....but I don't know....and we do not install anyway...and it hasn't been used since electric...:wink:

I vote for removal!

I guess the only additional features not included in moveit are

@mathias-luedtke
Copy link
Contributor

mathias-luedtke commented Feb 19, 2017

TL;DR: +1 for removal

GetPositionIKExtended.srv

This is used in 3 old python scripts https://github.com/search?q=org%3Aipa320+GetPositionIKExtended&type=Code
But the providing node is gone anyway.

and the converter tool

It is probably outdated as well.

@fmessmer fmessmer closed this as completed Mar 5, 2017
@fmessmer
Copy link
Member Author

removed for kinetic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants