[ioctl] Add stake2 transferownership command #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
millken
requested review from
CoderZhi,
dustinxie,
Liuhaai,
envestcc and
a team
as code owners
1 task
CoderZhi
approved these changes
May 30, 2024
e2etest/native_staking_test.go
Outdated
| require.EqualValues(iotextypes.ReceiptStatus_Success, ccto.Status) | ||
| require.NoError(checkCandidateState(sf, candidate1Name, newOwner1.String(), selfStake, cand1Votes, newOwner1)) | ||
| }) | ||
| t.Run("candidate transfer ownership to a exist candidate", func(t *testing.T) { |
e2etest/native_staking_test.go
Outdated
| require.EqualValues(iotextypes.ReceiptStatus_ErrUnauthorizedOperator, ccto.Status) | ||
| require.NoError(checkCandidateState(sf, candidate1Name, cand1Addr.String(), selfStake, cand1Votes, cand1Addr)) | ||
| }) | ||
| t.Run("candidate transfer ownership to a invalid address", func(t *testing.T) { |
dustinxie
reviewed
Jun 3, 2024
action/protocol/staking/candidate.go
Outdated
| @@ -101,7 +104,7 @@ func (d *Candidate) isSelfStakeBucketSettled() bool { | |||
|
|
|||
| // Collision checks collsion of 2 candidates | |||
| func (d *Candidate) Collision(c *Candidate) error { | |||
| if address.Equal(d.Owner, c.Owner) { | |||
| if address.Equal(d.Owner, c.Owner) || address.Equal(d.GetIdentifier(), c.GetIdentifier()) { | |||
There was a problem hiding this comment.
i think this part has been merged, can you rebase?
dustinxie
reviewed
Jun 4, 2024
e2etest/native_staking_test.go
Outdated
| @@ -491,6 +545,7 @@ func TestNativeStaking(t *testing.T) { | |||
| cfg.Genesis.FbkMigrationBlockHeight = 1 | |||
| cfg.Genesis.TsunamiBlockHeight = 0 | |||
There was a problem hiding this comment.
each hard-fork height needs to be >= previous one
dustinxie
reviewed
Jun 4, 2024
| } | ||
| _stake2TransferOwnershipCmdShorts = map[config.Language]string{ | ||
| config.English: "Transfer Ownership on IoTeX blockchain", | ||
| config.Chinese: "在IoTeX区块链上转移候选人", |
dustinxie
approved these changes
Jun 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ioctl Add stake2 transferownership command, allow delegate to transfer the ownership to a new address
Related PR:
#4236
#4239
#4245
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: