[action] Transfering delegate ownership, add CandidateTransferOwnership #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millken
requested review from
CoderZhi,
dustinxie,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
reviewed
Apr 17, 2024
envestcc
reviewed
Apr 17, 2024
envestcc
reviewed
Apr 17, 2024
envestcc
reviewed
Apr 17, 2024
dustinxie
reviewed
Apr 18, 2024
| if !IsValidCandidateName(act.Name()) { | ||
| return ErrInvalidCanName | ||
| } | ||
|
|
This was referenced Apr 23, 2024
1 task
dustinxie
reviewed
Apr 23, 2024
|
also you'll need to add this new action type into envelope's |
dustinxie
reviewed
Apr 23, 2024
added in #4250 |
4250 is for ioctl, this change should be added in this PR |
|
add guarding test case in |
CoderZhi
approved these changes
May 4, 2024
| func (act *CandidateTransferOwnership) Payload() []byte { return act.payload } | ||
|
|
||
| // NewOwner returns the new owner address | ||
| func (act *CandidateTransferOwnership) NewOwner() address.Address { return act.newOwner } |
There was a problem hiding this comment.
newOwner may not be a good name for the function and the parameter
|
|
||
| // IntrinsicGas returns the intrinsic gas of a CandidateTransferOwnership | ||
| func (act *CandidateTransferOwnership) IntrinsicGas() (uint64, error) { | ||
| payloadSize := uint64(len(act.Payload())) |
| func (act *CandidateTransferOwnership) Cost() (*big.Int, error) { | ||
| intrinsicGas, _ := act.IntrinsicGas() | ||
|
|
||
| fee := big.NewInt(0).Mul(act.GasPrice(), big.NewInt(0).SetUint64(intrinsicGas)) |
envestcc
approved these changes
May 22, 2024
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transfering delegate ownership to a new address PART 1
protobuf changes: https://github.com/iotexproject/iotex-proto/pull/147/files
Related PR:
#4236
#4239
#4245
#4250
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: