Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegation id randomly not found #1454

Merged
merged 7 commits into from
Apr 26, 2024
Merged

fix: delegation id randomly not found #1454

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
330cae5
feat: delegation id random errors.
panteleymonchuk Apr 25, 2024
38b03c1
Change Promise.all to Promise.allSettled
panteleymonchuk Apr 25, 2024
cb106e3
Merge remote-tracking branch 'origin/dev' into feat/issues-1424-deleg…
panteleymonchuk Apr 25, 2024
0a22aed
feat: Change Promise.allSettled to Promise.any back.
panteleymonchuk Apr 26, 2024
b73d6f0
Merge branch 'dev' into feat/issues-1424-delegation-id-not-found
msarcev Apr 26, 2024
1207d24
feat: PR comments.
panteleymonchuk Apr 26, 2024
d36a296
feat: PR comments pt2.
panteleymonchuk Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
308 changes: 186 additions & 122 deletions api/src/utils/nova/searchExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,165 +24,242 @@ export class SearchExecutor {

if (searchQuery.blockId) {
promises.push(
this.executeQuery(
this.apiService.block(searchQuery.blockId),
(response) => {
promisesResult = {
block: response.block,
error: response.error || response.message,
};
},
"Block fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.block(searchQuery.blockId)
.then((response) => {
if (response.block) {
promisesResult = {
block: response.block,
};
resolve();
} else {
reject(new Error("Block fetch failed"));
}
})
.catch((_) => {
reject(new Error("Block fetch failed"));
});
}),
);
}

if (searchQuery.outputId) {
promises.push(
this.executeQuery(
this.apiService.outputDetails(searchQuery.outputId),
(response) => {
promisesResult = {
output: response.output,
error: response.error || response.message,
};
},
"Output fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.outputDetails(searchQuery.outputId)
.then((response) => {
if (response.output) {
promisesResult = {
output: response.output,
};
resolve();
} else {
reject(new Error("Output fetch failed"));
}
})
.catch((_) => {
reject(new Error("Output fetch failed"));
});
}),
);
}

if (searchQuery.accountId) {
promises.push(
this.executeQuery(
this.apiService.accountDetails(searchQuery.accountId),
(response) => {
promisesResult = {
accountId: response.accountOutputDetails ? searchQuery.accountId : undefined,
error: response.error || response.message,
};
},
"Account id fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.accountDetails(searchQuery.accountId)
.then((response) => {
if (response.accountOutputDetails) {
promisesResult = {
accountId: searchQuery.accountId,
};
resolve();
} else {
reject(new Error("Account id fetch failed"));
}
})
.catch((_) => {
reject(new Error("Account id fetch failed"));
});
}),
);
}

if (searchQuery.nftId) {
promises.push(
this.executeQuery(
this.apiService.nftDetails(searchQuery.nftId),
(response) => {
promisesResult = {
nftId: response.nftOutputDetails ? searchQuery.nftId : undefined,
error: response.error || response.message,
};
},
"Nft id fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.nftDetails(searchQuery.nftId)
.then((response) => {
if (response.nftOutputDetails) {
promisesResult = {
nftId: searchQuery.nftId,
};
resolve();
} else {
reject(new Error("Nft id fetch failed"));
}
})
.catch((_) => {
reject(new Error("Nft id fetch failed"));
});
}),
);
}

if (searchQuery.anchorId) {
promises.push(
this.executeQuery(
this.apiService.anchorDetails(searchQuery.anchorId),
(response) => {
promisesResult = {
anchorId: response.anchorOutputDetails ? searchQuery.anchorId : undefined,
error: response.error || response.message,
};
},
"Anchor id fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.anchorDetails(searchQuery.anchorId)
.then((response) => {
if (response.anchorOutputDetails) {
promisesResult = {
anchorId: searchQuery.anchorId,
};
msarcev marked this conversation as resolved.
Show resolved Hide resolved
} else {
reject(new Error("Anchor id fetch failed"));
}
})
.catch((_) => {
reject(new Error("Anchor id fetch failed"));
});
}),
);
}

if (searchQuery.delegationId) {
promises.push(
this.executeQuery(
this.apiService.delegationDetails(searchQuery.delegationId),
(response) => {
promisesResult = {
output: response.output,
error: response.error || response.message,
};
},
"Delegation id fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.delegationDetails(searchQuery.delegationId)
.then((response) => {
if (response.output) {
promisesResult = {
output: response.output,
};
resolve();
} else {
reject(new Error("Anchor id fetch failed"));
msarcev marked this conversation as resolved.
Show resolved Hide resolved
}
})
.catch((_) => {
reject(new Error("Anchor id fetch failed"));
});
}),
);
}

if (searchQuery.transactionId) {
promises.push(
this.executeQuery(
this.apiService.transactionIncludedBlock(searchQuery.transactionId),
(response) => {
promisesResult = {
transactionBlock: response.block,
error: response.error || response.message,
};
},
"Transaction included block fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.transactionIncludedBlock(searchQuery.transactionId)
.then((response) => {
if (response.block) {
promisesResult = {
transactionBlock: response.block,
};
resolve();
} else {
reject(new Error("Transaction included block fetch failed"));
}
})
.catch((_) => {
reject(new Error("Transaction included block fetch failed"));
});
}),
);
}

if (searchQuery.foundryId) {
promises.push(
this.executeQuery(
this.apiService.foundryDetails(searchQuery.foundryId),
(response) => {
promisesResult = {
foundryId: response.foundryDetails ? searchQuery.foundryId : undefined,
error: response.error || response.message,
};
},
"Foundry details fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.foundryDetails(searchQuery.foundryId)
.then((response) => {
if (response.foundryDetails) {
promisesResult = {
foundryId: searchQuery.foundryId,
};
resolve();
} else {
reject(new Error("Foundry details fetch failed"));
}
})
.catch((_) => {
reject(new Error("Foundry details fetch failed"));
});
}),
);
}

if (searchQuery.slotIndex) {
promises.push(
this.executeQuery(
this.apiService.getSlotCommitment(searchQuery.slotIndex),
(_) => {
promisesResult = {
slotIndex: String(searchQuery.slotIndex),
};
},
"Slot commitment fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.getSlotCommitment(searchQuery.slotIndex)
.then((response) => {
if (searchQuery.slotIndex) {
msarcev marked this conversation as resolved.
Show resolved Hide resolved
promisesResult = {
slotIndex: String(searchQuery.slotIndex),
};
resolve();
} else {
reject(new Error("Slot commitment fetch failed"));
}
})
.catch((_) => {
reject(new Error("Slot commitment fetch failed"));
});
}),
);
}

if (searchQuery.slotCommitmentId) {
promises.push(
this.executeQuery(
this.apiService.getCommitment(searchQuery.slotCommitmentId),
(result) => {
promisesResult = {
slotIndex: String(result.slot.slot),
};
},
"Slot commitment fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.getCommitment(searchQuery.slotCommitmentId)
.then((response) => {
if (response?.slot?.slot) {
msarcev marked this conversation as resolved.
Show resolved Hide resolved
promisesResult = {
slotIndex: String(response.slot.slot),
};
resolve();
} else {
reject(new Error("Slot commitment fetch failed"));
}
})
.catch((_) => {
reject(new Error("Slot commitment fetch failed"));
});
}),
);
}

if (searchQuery.tag) {
promises.push(
this.executeQuery(
this.apiService.taggedOutputs(searchQuery.tag),
(response) => {
if (!response.basicOutputs.error || !response.nftOutputs.error) {
promisesResult = {
taggedOutputs: response,
};
}
},
"Tagged details fetch failed",
),
new Promise((resolve, reject) => {
this.apiService
.taggedOutputs(searchQuery.tag)
.then((response) => {
if (!response.basicOutputs.error || !response.nftOutputs.error) {
msarcev marked this conversation as resolved.
Show resolved Hide resolved
promisesResult = {
taggedOutputs: response,
};
resolve();
} else {
reject(new Error("Tagged details fetch failed"));
}
})
.catch((_) => {
reject(new Error("Tagged details fetch failed"));
});
}),
);
}

Expand All @@ -200,17 +277,4 @@ export class SearchExecutor {

return { message: "Nothing found" };
}

private async executeQuery<T>(query: Promise<T>, successHandler: (result: T) => void, failureMessage: string): Promise<void> {
try {
const result = await query;
if (result) {
successHandler(result);
} else {
throw new Error(failureMessage);
}
} catch {
throw new Error(`${failureMessage}`);
}
}
}
Loading