Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delegation id randomly not found #1454

Merged
merged 7 commits into from
Apr 26, 2024
Merged

fix: delegation id randomly not found #1454

merged 7 commits into from
Apr 26, 2024

Conversation

panteleymonchuk
Copy link
Collaborator

@panteleymonchuk panteleymonchuk commented Apr 25, 2024 •
edited
Loading

Description of change

Closes #1424

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk linked an issue Apr 25, 2024 that may be closed by this pull request
[Task]: Delegation ID not found #1424
Closed
@panteleymonchuk
feat: delegation id random errors.
330cae5 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Change Promise.all to Promise.allSettled
38b03c1 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk force-pushed the feat/issues-1424-delegation-id-not-found branch from cf33f71 to 38b03c1 Compare April 25, 2024 17:00
@panteleymonchuk panteleymonchuk marked this pull request as ready for review April 25, 2024 17:03
msarcev
msarcev requested changes Apr 26, 2024
View reviewed changes
api/src/utils/nova/searchExecutor.ts Outdated Show resolved Hide resolved
api/src/utils/nova/searchExecutor.ts Outdated Show resolved Hide resolved
api/src/utils/nova/searchExecutor.ts Show resolved Hide resolved
api/src/utils/nova/searchExecutor.ts Outdated Show resolved Hide resolved
api/src/utils/nova/searchExecutor.ts Outdated Show resolved Hide resolved
@panteleymonchuk panteleymonchuk requested a review from msarcev April 26, 2024 13:24
@begonaalvarezd begonaalvarezd changed the title feat: delegation id random errors. fix: delegation id randomly not found Apr 26, 2024
@begonaalvarezd begonaalvarezd merged commit 6aecb37 into dev Apr 26, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/issues-1424-delegation-id-not-found branch April 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msarcev msarcev msarcev approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@brancoder brancoder Awaiting requested review from brancoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Delegation ID not found
3 participants
@panteleymonchuk @begonaalvarezd @msarcev