Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove the karma / browserstack test infrastructure #5600

Merged
merged 1 commit into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,7 @@ When a `git push` is made to a branch, Stencil's CI is designed to stop existing
branch.
A new CI run (of each workflow) will begin upon stopping the existing job(s) using the new `HEAD` of the branch.

### BrowserStack (`browserstack.yml`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for this PR, but before we mark STENCIL-1239 as done - we should put together a couple of sentences here for the WDIO job. I'll add something to the AC of that ticket now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow-up PR for that and the other README change


This workflow is used to run a series of integration tests using [BrowserStack](https://www.browserstack.com).
The exact details of which browsers are targeted can be found in the [karma directory](../../test/karma) of the project.

Running this workflow requires a username + access key in order to access BrowserStack.
These credentials are stored as secrets in GitHub.

This workflow differs from most in that it is designed to run on `pull_request_target` triggers.
This allows community provided pull requests to run BrowserStack tests.

## Repository Configuration

Each of the workflows described in the [workflows section](#workflows) of this document must be configured in the
Stencil GitHub repository to be _required_ to pass in order to land code in the `main` branch.
Stencil GitHub repository to be _required_ to pass in order to land code in the `main` branch.
108 changes: 0 additions & 108 deletions .github/workflows/test-browserstack.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/test-wdio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
- name: Checkout Code
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Use Node Version from Volta (Karma)
- name: Use Node Version from Volta
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
# pull the version to use from the volta key in package.json
node-version-file: './test/karma/package.json'
node-version-file: './test/wdio/package.json'
cache: 'npm'

- name: Install dependencies
Expand Down
3 changes: 0 additions & 3 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ node_modules/
coverage/

# output from compiling Stencil projects for testing purposes
test/karma/test-sibling/
test/karma/tmp-compiled-tests/
test/**/dist/
test/**/dist-react/
test/**/hydrate/
Expand All @@ -49,7 +47,6 @@ test/docs-json/docs.d.ts
test/docs-json/docs.json

# minified angular that exists in the test directory
test/karma/test-app/assets/angular.min.js

# generated screenshot files
/screenshot/index.js
Expand Down
23 changes: 0 additions & 23 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -255,29 +255,6 @@
"${workspaceFolder}/../ionic-docs/stencil.config.ts"
],
"protocol": "inspector"
},
{
"type": "node",
"request": "launch",
"name": "Karma",
"args": [
"${workspaceFolder}/bin/stencil",
"build",
"--max-workers=0",
"--dev",
"--config",
"${workspaceFolder}/test/karma/stencil.config.ts"
],
"protocol": "inspector"
},
alicewriteswrongs marked this conversation as resolved.
Show resolved Hide resolved
{
"type": "node",
"request": "launch",
"name": "Karma Prerender",
"args": [
"${workspaceFolder}/test/karma/test-prerender/prerender.js"
],
"protocol": "inspector"
}
]
}
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,9 @@
"test.dist": "node scripts/build --validate-build",
"test.end-to-end": "cd test/end-to-end && npm ci && npm test && npm run test.dist",
"test.jest": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js",
"test.karma": "cd test/karma && npm ci && npm run karma",
"test.karma.prod": "cd test/karma && npm ci && npm run karma.prod",
"test.wdio": "cd test/wdio && npm ci && npm run test",
"test.wdio.testOnly": "cd test/wdio && npm ci && npm run wdio",
"test.prod": "npm run test.dist && npm run test.end-to-end && npm run test.jest && npm run test.karma && npm run test.sys.node && npm run test.testing && npm run test.analysis",
"test.prod": "npm run test.dist && npm run test.end-to-end && npm run test.jest && npm run test.wdio && npm run test.sys.node && npm run test.testing && npm run test.analysis",
"test.testing": "node scripts/test/validate-testing.js",
"test.watch": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --watch",
"test.watch-all": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --watchAll --coverage",
Expand Down
5 changes: 1 addition & 4 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,4 @@ In many cases, Stencil can be used as a drop in replacement for traditional fron

Thanks for your interest in contributing!
Please take a moment to read up on our guidelines for [contributing](https://github.com/ionic-team/stencil/blob/main/CONTRIBUTING.md).
Please note that this project is released with a [Contributor Code of Conduct](https://github.com/ionic-team/stencil/blob/main/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.

### Thanks
Stencil's internal testing suite is supported by the [BrowserStack Open-Source Program](https://www.browserstack.com/open-source)
Please note that this project is released with a [Contributor Code of Conduct](https://github.com/ionic-team/stencil/blob/main/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.
22 changes: 4 additions & 18 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,6 @@
matchPackageNames: ['@types/jest', 'jest'],
allowedVersions: '<=29'
},
{
// We intentionally run the karma tests against the oldest LTS of Node we support.
// Prevent renovate from trying to bump node
matchFileNames: ['test/karma/package.json'],
matchDepNames: ['node'],
allowedVersions: '<=16'
},
{
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
// Prevent renovate from trying to bump node
Expand All @@ -114,27 +107,20 @@
allowedVersions: '<=16'
},
{
// We intentionally run the karma tests against the oldest LTS of Node we support.
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
// Prevent renovate from trying to bump node
matchFileNames: ['test/karma/package.json'],
matchFileNames: ['test/wdio/package.json'],
matchPackageNames: ['@types/node'],
allowedVersions: '<=16'
},
{
// We intentionally run the karma tests against the oldest LTS of Node we support.
// We intentionally run the WebdriverIO tests against the oldest LTS of Node we support.
// Prevent renovate from trying to bump npm and keep it in sync with a version that's supported by the version of
// Node we run against.
matchFileNames: ['test/karma/package.json'],
matchFileNames: ['test/wdio/package.json'],
matchDepNames: ['npm'],
allowedVersions: '<=8'
},
{
// We intentionally run the karma tests against TypeScript v5.2 as an attempt to update has failed
// due to incompatibilities with `karma-typescript`. Prevent renovate from trying to bump TypeScript.
matchFileNames: ['test/karma/package.json'],
matchDepNames: ['typescript'],
allowedVersions: '<5.3'
},
{
matchPackageNames: ['rollup'],
matchPackagePrefixes: ['@rollup'],
Expand Down
2 changes: 0 additions & 2 deletions test/karma/.gitignore

This file was deleted.

116 changes: 0 additions & 116 deletions test/karma/README.md

This file was deleted.

10 changes: 0 additions & 10 deletions test/karma/constants.js

This file was deleted.

Loading
Loading