chore(test): remove the karma / browserstack test infrastructure #5600
Conversation
|
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/testing/puppeteer/puppeteer-element.ts | 21 |
| src/runtime/client-hydrate.ts | 20 |
| src/screenshot/connector-base.ts | 19 |
| src/runtime/vdom/vdom-render.ts | 17 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/prerender/prerender-queue.ts | 13 |
| src/compiler/sys/in-memory-fs.ts | 13 |
| src/runtime/connected-callback.ts | 13 |
| src/runtime/set-value.ts | 13 |
| src/compiler/output-targets/output-www.ts | 12 |
| src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
| src/compiler/transformers/transform-utils.ts | 12 |
| src/compiler/transpile/transpile-module.ts | 12 |
| src/mock-doc/test/attribute.spec.ts | 12 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2322 | 361 |
| TS2345 | 345 |
| TS18048 | 204 |
| TS18047 | 82 |
| TS2722 | 37 |
| TS2532 | 24 |
| TS2531 | 21 |
| TS2454 | 14 |
| TS2790 | 11 |
| TS2352 | 9 |
| TS2769 | 8 |
| TS2538 | 8 |
| TS2416 | 7 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2430 | 1 |
Unused exports report
There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/utils/index.ts | 269 | normalize |
| src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 115 | Env |
| src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8470404067/artifacts/1367320231 If your browser saves files to |
| @@ -117,18 +117,7 @@ When a `git push` is made to a branch, Stencil's CI is designed to stop existing | |||
| branch. | |||
| A new CI run (of each workflow) will begin upon stopping the existing job(s) using the new `HEAD` of the branch. | |||
|
|
|||
| ### BrowserStack (`browserstack.yml`) | |||
There was a problem hiding this comment.
Not required for this PR, but before we mark STENCIL-1239 as done - we should put together a couple of sentences here for the WDIO job. I'll add something to the AC of that ticket now
There was a problem hiding this comment.
I'll do a follow-up PR for that and the other README change
| @@ -1,116 +0,0 @@ | |||
| # Karma Testing | |||
There was a problem hiding this comment.
As a part of STENCIL-1239 we should make sure we create an equivalent README that tell folks how to create a test here (from the perspective of a new team member or member of the community asked to write a wdio test)
There was a problem hiding this comment.
I'll do that in a follow-up PR
We no longer want to run the workflow nor do we want this code hanging around! Now that #5458 is closed we don't need to run the karma tests anymore. STENCIL-1239
alicewriteswrongs
force-pushed
the
ap/stop-karma-fail
branch
from
871e117 to
5243518
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
We no longer want to run the workflow nor do we want this code hanging around! Now that #5458 is closed we don't need to run the karma tests anymore.
STENCIL-1239
What is the current behavior?
Although we've removed all of the Karma tests we still have the Karma / Browerstack infrastructure hanging around. Unfortunately it's still causing build failures, such as this one: https://github.com/ionic-team/stencil/actions/runs/8466788671/job/23196360326?pr=5598
So we should remove it ASAP.
What is the new behavior?
No more Karma! No more browserstack!
Does this introduce a breaking change?
Testing
If the build passes I believe we're good.
In order to land this PR though we'll need to remove the required check for the browserstack gh actions workflow. We should also then delete the related secret.