Remove duplicate button-default-border variable definitions. #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5875ebc.
This reverts commit bfd9f08.
Setup empty arrays before evaluating ionic.CSS
According to the Swiper documentation, the pagination parameter can receive a string with a selector or directly the html element. Passing directly the html element ensures that the pagination works with multiple sliders. Resolves ionic-team#4837.
…transform3d Change translateY to 3d
According to the unit tests this expects pixel values.
…t-active-border made variables for button-default-border and button-default-active-bordermade variables ionic-team#5576
Fix for issue 2521
Update headerFooterBar.js
fix(bar): set correct title bar height
fix(loader): make the loader service return a promise instead of the …
Update CHANGELOG.md for 1.3.1 release
Correction in the documentation of usage. The indexes were being accessed in data instead of data.slider (or $scope.slider).
…r-configurable Make button border style configurable
| $button-default-active-bg: $button-stable-active-bg !default; | ||
| $button-default-active-border: $button-stable-active-border !default; | ||
| $button-default-active-border: null !default; |
There was a problem hiding this comment.
Why remove $button-stable-active-border from this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
$button-default-border and $button-default-active-border are defined twice.
Changes proposed in this pull request:
Ionic Version: 1.3.1
Fixes: Complements #5576 and #6532